export ReactChartJs #169

Activity

1. CodePlayer7

   changed the title [-]exports `ReactChartJs` rather than `react-chartjs` so we can simply call `ReactChartJs` rather than `window['react-chartjs']`[/-] [+]export `ReactChartJs`[/+] on Dec 28, 2016
2. Jareechang commented on Jan 14, 2018

   

   Jareechang

   on Jan 14, 2018

   Collaborator

   More actions

   @CallMeXYZ, can you provide more details on this issue ?
3. CodePlayer7 commented on Jan 16, 2018

   

   CodePlayer7

   on Jan 16, 2018

   Author

   More actions

   when importing this project by url or cdn, we need to call window['react-chartjs'] to get the reference. If exporting as ReactChartJs then we can simply call ReactChartJs
4. morenoh149 commented on Mar 6, 2018

   

   morenoh149

   on Mar 6, 2018

   More actions

   This seems like a small enough improvement one could submit a PR for. Would one change this file? https://github.com/reactjs/react-chartjs/blob/master/index.js
5. Jareechang commented on Mar 6, 2018

   

   Jareechang

   on Mar 6, 2018

   Collaborator

   More actions

   Hi Everyone, I believe this is specified in webpack and not in the source code itself. I am happy to take PRs.

   That being said, my only concern with this request is that it may break other people's projects using window['react-chartjs'] if we change it. Unfortunately, I am a little hesitant with this change.

   Please see:

   • Webpack Config
   • Compiled Source

   Helpful resource:

   Webpack >2.0 Doc