This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 19, 2019. It is now read-only.
modern browser colors cause an error #83
Description
Hi there!
I'm converting a react library from svg to react-art, and I got hung up on using colors like "tomato", which cause an error, and result in nothing being rendered. I tracked the problem down to the art library, and opened a PR there. sebmarkbage/art#12. I'd love a version bump whenever that lands.
Thanks!
Activity
boygirl commentedon Jan 24, 2016
P.S. you can test out this change in art on my branch https://github.com/formidablelabs/react-art/tree/supportBrowserColors
sebmarkbage commentedon Apr 26, 2016
See my comment in sebmarkbage/art#12
We'd have to make a solid case for why everyone else using this library with custom colors should have to download this list of hardcoded colors. Generally I think it makes more sense to define your own list of hardcoded colors.
E.g.
myColorSet.highlightedRedormyColorSet.buttonColor. You can have your own list just represent the built-in browser colors if you want.boygirl commentedon Apr 26, 2016
@sebmarkbage see comment on sebmarkbage/art#12