This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Remove dependency on react-dom #68
Description
With 0.14 React release the core React library is split from the DOM renderer in order to encourage projects like this to create their own rendering system. Are there plans to make a new renderer or will react-art continue to use react-dom? Will there be tutorials on the React site in the future on how authors can create their own renderer (what integration methods are required etc)?
Activity
sebmarkbage commentedon Oct 8, 2015
Yea, the idea is that eventually React ART will integrate its own renderer and eventually we'll have a publicly supported way of doing so. The big blocker is making it work seamlessly across renderers with context etc.
This is related too. react/react#4230
sebmarkbage commentedon Oct 8, 2015
Note that even
<Surface />doesn't need a dependency onreact-domsince it can render the tag as a string and the ref resolves directly to the node.sophiebits commentedon Oct 8, 2015
It already doesn't depend on
react-dom:react-art/package.json
Lines 20 to 26 in d98e74e
(That's not a practical help right now since there aren't any other DOM renderers.)
fabslab commentedon Oct 8, 2015
But react-art assumes the user is using ReactDOM doesn't it? As given in your example https://github.com/reactjs/react-art/blob/master/examples/vector-widget/app.js#L7
sebmarkbage commentedon Oct 8, 2015
Yea this probably breaks without it. https://github.com/reactjs/react-art/blob/master/src/ReactART.js#L198
sophiebits commentedon Oct 8, 2015
@sebmarkbage I think that's actually fine? That points to the composite.
sebmarkbage commentedon Oct 8, 2015
@spicyj Not if that composite was rendered by a different renderer than
react-dom. Unless it also uses the sameReactInstanceMap. Note that this is the Surface so it shouldn't have been rendered by ReactART.