Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

Event Handler Properties Change on Shape Ignored? #65

Open

Description

@joewood

I hit a problem where subsequent render iterations on a Shape with a key in a collection didn't modify the property. The original bound mousedown event handler was still being used by the ART Shape. Checking the code, does Shape process componentWillReceiveProps ? I can see the call to applyNodeProps but it's not clear if new event handlers are re-applied.

Activity

  1. sebmarkbage commented on Sep 24, 2015

    @sebmarkbage
    Contributor

    It should: https://github.com/reactjs/react-art/blob/master/src/ReactART.js#L354

    And the listeners should be replaced: https://github.com/reactjs/react-art/blob/master/src/ReactART.js#L277

    Do you have a reproducible example or perhaps a unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions