This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Repository navigation
This repository was archived by the owner on Jul 19, 2019. It is now read-only.
render mode is unconfigurable #54
Description
I have read the issue 17 and test source.
#17
https://github.com/reactjs/react-art/blob/master/src/__tests__/ReactART-test.js#L55-L59
And I think there is no way to change the render mode.
In ReactART.js, there is requiring the art/modes/fast, that decide the mode used in ReactART.
@sebmarkbage You said that is already configurable and already do this in the unit test.
Actually L56-L59 in ReactART-test.js do nothing about ReactART Object.
I think you can just delete the L14 in ReactART.js, and let us choose the mode freely.
Activity
webxl commentedon Sep 9, 2015
I agree with @fumihwh. The unit test has access to the dependency's API directly, whereas any application built on top of this doesn't. Mode needs to be exposed in ReactART, along with the available modes (e.g. ReactART.AvailableModes.SVG). And ideally you could change the mode with a component property.
varghesep commentedon Sep 17, 2015
@fumihwh + I'm also looking for a solution.
shripadk commentedon Oct 3, 2015
+1. Would be great if the mode is configureable.
zemlanin commentedon Oct 28, 2015
+1
andru commentedon Jan 1, 2016
+1 Also looking to have this configurable