Skip to content

conditional-rendering - #64

Merged
sorousht merged 19 commits into
reactjs:masterfrom
sorousht:black-sheep777-ConditionalRendering
Dec 15, 2019
Merged

sorousht merged 19 commits into
reactjs:masterfrom
sorousht:black-sheep777-ConditionalRendering

Conversation

@sorousht

Copy link
Copy Markdown
Contributor

This PR completes the translation of @black-sheep777 (#47)

blacksheepIV and others added 5 commits April 10, 2019 15:37
The added words are based on the recent discussions on issue#41
…7/fa.reactjs.org into black-sheep777-ConditionalRendering
The PR was left for 30 days and I decided to apply the changes
and merge it inorder to prevent it from decaying
@sorousht
sorousht requested review from sJJdGG and zahrajoulaei May 10, 2019 16:58
@netlify

netlify Bot commented May 10, 2019 •

Copy link
Copy Markdown

Deploy preview for fa-reactjs ready!

Built with commit 6885094

https://deploy-preview-64--fa-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request May 11, 2019
44 of 87 tasks
sJJdGG
sJJdGG previously requested changes Jun 3, 2019
Comment thread content/docs/conditional-rendering.md Outdated
Comment thread content/docs/conditional-rendering.md Outdated
Comment thread content/docs/conditional-rendering.md Outdated

ReactDOM.render(
// Try changing to isLoggedIn={true}:
// تغییر isLoggedIn={true} را امتحان کنید

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

توی خروجی سایت این بخش بد نشون داده میشه که به نظرم مربوط به موتور رندر markdown میشه که گتسبی استفاده میکنه. نیاز به یه خرده تحقیق بیشتر داره که راه حلش رو توی گتسبی پیدا کنیم و این مشکل رو یه بار برای همیشه برای همه کامنت های توی کد حل کنیم. خودم هم در اولین فرصت روش کار میکنم.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sJJdGG آره این مشکل آزار دهنده هست توی کد‌ها و خیلی خوب میشه اگه حل بشه

Comment thread content/docs/conditional-rendering.md Outdated
Comment thread content/docs/conditional-rendering.md Outdated
Comment thread content/docs/conditional-rendering.md Outdated
Comment thread content/docs/conditional-rendering.md Outdated
Comment thread content/docs/conditional-rendering.md Outdated
Comment thread content/docs/conditional-rendering.md Outdated
@blacksheepIV

Copy link
Copy Markdown
Contributor

@sorousht I appreciate your help. I'm kinda new to this PR thing, should I wait for the 3rd reviewer or proceed with changing the translation & making a new PR?

@sorousht

Copy link
Copy Markdown
Contributor Author

@black-sheep777 You did not show up since you submitted your PR #47. So I had to close that and opened a new one in order to continue your translation. Now It's almost done. If you have any comment on this page, please leave your comments here, otherwise, if you are interested in translating another page, write a comment on issue #1, then I will assign the desired page to you.

sorousht and others added 14 commits June 16, 2019 15:43
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
Co-Authored-By: sJJdGG <25764288+sJJdGG@users.noreply.github.com>
…usht/fa.reactjs.org into black-sheep777-ConditionalRendering
@sorousht
sorousht requested a review from sJJdGG June 16, 2019 14:20
@sorousht
sorousht removed the request for review from sJJdGG October 4, 2019 13:35
@sorousht
sorousht requested a review from seven-deuce December 15, 2019 17:58

@seven-deuce seven-deuce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for merge

@sorousht
sorousht dismissed sJJdGG’s stale review December 15, 2019 18:27

Waiting so long to be approved

@sorousht
sorousht merged commit e16a18a into reactjs:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants