Skip to content

translation of Sharing State Between Components #357 - #360

Merged
rezvani2647 merged 2 commits into
reactjs:mainfrom
Ehsan-Yari:main
Sep 29, 2023
Merged

translation of Sharing State Between Components #357#360
rezvani2647 merged 2 commits into
reactjs:mainfrom
Ehsan-Yari:main

Conversation

@Ehsan-Yari

@Ehsan-Yari Ehsan-Yari commented Sep 19, 2023

Copy link
Copy Markdown

@Ehsan-Yari Ehsan-Yari mentioned this pull request Sep 19, 2023
Closed
@anna-abadi anna-abadi mentioned this pull request Sep 26, 2023
Open
@rezvani2647

rezvani2647 commented Sep 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

please remove unnecessarily div or any other tags and upadte this PR.
we should not add something to the file we only change the contents to Farsi.

thank you for your time. :-)

@Ehsan-Yari

Ehsan-Yari commented Sep 28, 2023

Copy link
Copy Markdown
Author

@rezvani2647 sorry about that.i thought i should wrap all paragraphs with div and give them RTL direction.
i removed all div containers and RTL styles as you said so my commit only contains the translation
thanks <3

@rezvani2647

rezvani2647 commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

@rezvani2647 sorry about that.i thought i should wrap all paragraphs with div and give them RTL direction. i removed all div containers and RTL styles as you said so my commit only contains the translation thanks <3

wonderful. 😍
Please, there's no need to sorry, you didn't do anything to sorry for. you've just done a great service. 🙏

@github-actions

github-actions Bot commented Sep 29, 2023

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@rezvani2647
rezvani2647 merged commit 60b2ab8 into reactjs:main Sep 29, 2023
@Ehsan-Yari

Ehsan-Yari commented Sep 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Author

@rezvani2647 thanks a lot.it was my pleasure to help.btw can you plase add me to contributors list ?

This branch had an error being deployed

1 failed deployment
Preview – fa-react-dev — f2e16759 Deployed Sep 28, 2023 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@rezvani2647 rezvani2647 rezvani2647 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ehsan-Yari @rezvani2647 @EhsanQwerty