Repository navigation
Translate page "Rendering Elements" - #28
Merged
Merged
Conversation
|
Deploy preview for fa-reactjs ready! Built with commit b06a454 |
sJJdGG
suggested changes
Mar 3, 2019
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Use a batter word for **Note** Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
zahrajoulaei
previously approved these changes
Mar 4, 2019
sJJdGG
suggested changes
Mar 4, 2019
sJJdGG
reviewed
Mar 4, 2019
Thanks to @sJJdGG Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Thanks to @sJJdGG Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
sJJdGG
reviewed
Mar 4, 2019
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
…ring-elements.md Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
sJJdGG
suggested changes
Mar 5, 2019
sJJdGG
left a comment
sJJdGG
left a comment
Contributor
There was a problem hiding this comment.
Render is more of a verb that does something and is a synonym of verb "make" and it'd better be translated to "رندر کردن" instead of "رندر شدن". "being rendered" is the one that should be translated to "رندر شدن". Or at least that's what I think.
@sorousht @zahrajoulaei What do you think?
sJJdGG
suggested changes
Mar 5, 2019
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
Contributor
Author
Yeah, your right. So I fix that. |
sJJdGG
suggested changes
Mar 7, 2019
sJJdGG
left a comment
sJJdGG
left a comment
Contributor
There was a problem hiding this comment.
Seems completely ok except this minor word placement
Co-Authored-By: sorousht <soroush.torkzadeh@gmail.com>
sJJdGG
self-requested a review
March 7, 2019 10:51
44 of 87 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.