Skip to content

React without ES6 translated - #179

Merged
sorousht merged 1 commit into
reactjs:masterfrom
hosseinAMD:react-without-es6-hosseinamd
Nov 22, 2020
Merged

sorousht merged 1 commit into
reactjs:masterfrom
hosseinAMD:react-without-es6-hosseinamd

Conversation

@hosseinAMD

Copy link
Copy Markdown
Contributor

Dear @sorousht

Take your time to review this page!
Good luck!

@netlify

netlify Bot commented Nov 8, 2020

Copy link
Copy Markdown

Deploy preview for fa-reactjs failed.

Built with commit b05ccea

https://app.netlify.com/sites/fa-reactjs/deploys/5fa7959a212a770008811dce

@hosseinAMD

hosseinAMD commented Nov 8, 2020 •

Copy link
Copy Markdown
Contributor Author

@sorousht
I can't understand the problem of tests failing.
I've done steps like other pages and only translated .md file
Can you check why the tests are failing?

Steps

git fetch upstream
git merge upstream/master
git checkout -b [branch-name]
git status
git add .
git commit -m "message"
git push origin [branch-name]

@sorousht sorousht left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

مثل همیشه عالی بود @hosseinAMD جان!

@sorousht

Copy link
Copy Markdown
Contributor

بررسی می کنم ببینم مشکل از چیه!

@sorousht
sorousht merged commit ee64768 into reactjs:master Nov 22, 2020
@sorousht

Copy link
Copy Markdown
Contributor

پول ریکوست قبول و ادغام شد!

@sorousht sorousht mentioned this pull request Nov 22, 2020
44 of 87 tasks

This branch was successfully deployed

1 active deployment
Preview — b05ccea3 Deployed Nov 8, 2020 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants