Skip to content

React.Component translated - #155

Closed
hosseinAMD wants to merge 2 commits into
reactjs:masterfrom
hosseinAMD:master
Closed

hosseinAMD wants to merge 2 commits into
reactjs:masterfrom
hosseinAMD:master

Conversation

@hosseinAMD

Copy link
Copy Markdown
Contributor

Finally!!!
This page was so long and Hard! :D
with many important aspects of translation because some sentences weren't understandable in Persian, So I've changed some of them regard to their content and purpose.
Thanks again!

P.S: I've updated my keyboard layout so Half-Space and other Persian characters shouldn't be a problem from now on!

@netlify

netlify Bot commented Jun 27, 2020 •

Copy link
Copy Markdown

Deploy preview for fa-reactjs ready!

Built with commit f3bae8d

https://deploy-preview-155--fa-reactjs.netlify.app

@sorousht

Copy link
Copy Markdown
Contributor

Great job @hosseinAMD!

Please give me some time to review it 😅

@hosseinAMD

Copy link
Copy Markdown
Contributor Author

Great job @hosseinAMD!

Please give me some time to review it 😅

@sorousht
Hi soroush
First, Thank you for your efforts
Second, I wonder to know if any advance happened in reviewing this page?

@sorousht

Copy link
Copy Markdown
Contributor

Hi @hosseinAMD
Thank you for collaborating as well!
I try to find some free time during the week to start reviewing this PR, but usually, I spend some time on weekends.
Would you like to start a new page in the meanwhile?

@hosseinAMD

Copy link
Copy Markdown
Contributor Author

Hi @hosseinAMD
Thank you for collaborating as well!
I try to find some free time during the week to start reviewing this PR, but usually, I spend some time on weekends.
Would you like to start a new page in the meanwhile?

Sure i can do it...
I will post a comment on Issue 1!

@hosseinAMD

Copy link
Copy Markdown
Contributor Author

@sorousht

I don't know it's correct or not but github merged my new translation pull request with this!
Anyway, here is my new translation file!

@sorousht

sorousht commented Jul 1, 2020

Copy link
Copy Markdown
Contributor

have you used a single branch for both PRs?

@hosseinAMD

Copy link
Copy Markdown
Contributor Author

have you used a single branch for both PRs?

@sorousht

No. I've used 2 different branches

@sorousht

sorousht commented Jul 2, 2020

Copy link
Copy Markdown
Contributor

Screenshot from 2020-07-02 09 21 33

The PR shows that you pushed your commits into branch master of your clone. You need two branches in which you have the changes only one page. If you need help for that, let me know :)

@hosseinAMD

Copy link
Copy Markdown
Contributor Author

Screenshot from 2020-07-02 09 21 33

The PR shows that you pushed your commits into branch master of your clone. You need two branches in which you have the changes only one page. If you need help for that, let me know :)

I've merged them in my local repo after pushing by ingle branches!
Let me take a look

@hosseinAMD

Copy link
Copy Markdown
Contributor Author

Screenshot from 2020-07-02 09 21 33
The PR shows that you pushed your commits into branch master of your clone. You need two branches in which you have the changes only one page. If you need help for that, let me know :)

I've merged them in my local repo after pushing by ingle branches!
Let me take a look

Created a different pull request for test utils... do you need a new one for here too?

@sorousht

sorousht commented Jul 4, 2020

Copy link
Copy Markdown
Contributor

Now you have 2 PRs, both having the same changes. In this one, the changes of content/docs/addons-test-utils.md should be reverted. For #156, the changes of content/docs/reference-react-component.md should be reverted. In result, you will have 2 PRs each containing only changes of one file.

@sorousht sorousht closed this Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants