Skip to content

Cannot update the root element.  #498

Description

@rmorshea

Current Situation

The 0.33.0 release introduced a regression in which the root element of the layout cannot be updated due to a typo on this line where doc should have been doc.current. We missed this during testing because, under the hood, the display() test fixture uses hotswap under the hood which always modifies one of its children (not the root element). We need an explicit test to check that the root element can be udpated.

Proposed Changes

  • quickly fix the issue and make a 0.33.1 release.
  • add a regression test to ensure this doesn't happen again in the future.

Implementation Details

No response

Activity

  1. added and removed on Sep 3, 2021
  2. added this to the 1.0 milestone on Jan 11, 2022
  3. added
    priority-3-lowMay be resolved one any timeline.
    and removed
    priority-2-moderateShould be resolved on a reasonable timeline.
    on Mar 28, 2022
  4. rmorshea commented on Jan 12, 2023

    @rmorshea
    CollaboratorAuthor

    If I remove json-patch as part of 1.0 I think I can just ignore this altogether.

  5. linked a pull request that will close this issueremove json patch #881on Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority-3-lowMay be resolved one any timeline.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions