Repository navigation
Utilize django include for HTTP URLs - #45
Merged
Archmonger merged 11 commits intoJan 21, 2022
Merged
Conversation
Archmonger
marked this pull request as ready for review
January 12, 2022 07:39
Archmonger
force-pushed
the
rm-idom-path-variable
branch
from
January 12, 2022 07:55
c9e9604 to
0d8640d
Compare
rmorshea
requested changes
Jan 13, 2022
Contributor
Author
|
On a tangent, do you think there's a chance we'll ever need more than one websocket endpoint for this repo? If so I can make similar changes on the WS end. Django channels is pretty new so there isn't any good styling guidelines to use for how to accomplish this. |
Contributor
|
I don't think so since one WS can serve any number of views. |
rmorshea
approved these changes
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IdomWebsocketat the module level to encourage type hintingIDOM_BASE_URLas it was difficult to use in conjunction with Django base URLsWhile this is a breaking change, I don't think mitigations are necessary since it seems like no one besides Conreq is currently using
django-idomon GitHub.