Skip to content

Add Type Checking To This Project And Add py.typed #91

Closed
Feature
#81
#86
Closed
Add Type Checking To This Project And Add py.typed#91
Feature
#81
#86
Labels
priority: 3 (low)

Description

@rmorshea
rmorshea
opened on Jul 15, 2022

Current Situation

Right now, we don't do any type checking with MyPy. We also do not distribute a py.typed marker file which would allow MyPy to work with django_idom when it's installed in other projects.

Proposed Actions

  • Add type checking with mypy. Preferably we'd eventually check in --strict mode, but we don't have to start there.
  • Distribute a py.typed marker file.

Activity

  1. rmorshea
    added
    flag: triage
    priority: 3 (low)
    type: feature
    and removed
    flag: triage
    on Jul 15, 2022

  2. Archmonger commented on Jul 15, 2022

    @Archmonger
    Archmonger
    on Jul 15, 2022
    Contributor

    What's the benefit of MyPy over stdlib type hints?

  3. rmorshea commented on Jul 15, 2022

    @rmorshea
    rmorshea
    on Jul 15, 2022
    ContributorAuthor

    MyPy is just the type checker. All the type hints will stay the same.

  4. Archmonger
    linked a pull request that will close this issueuse_query and use_mutation #86on Sep 14, 2022
  5. Archmonger
    linked a pull request that will close this issueView to Component #81on Sep 14, 2022
  6. rmorshea
    closed this as completedin #86on Sep 15, 2022
  7. Archmonger
    added the
    Feature
    issue type on Mar 14, 2025
  8. Archmonger
    removed
    type: feature
    on Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: 3 (low)

    Type

    Feature

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions