Repository navigation
move Libraries/Animated to packages/animated (@react-native/animated) - #50816
Closed
SGamrekelashvili wants to merge 3 commits into
Closed
SGamrekelashvili wants to merge 3 commits into
SGamrekelashvili wants to merge 3 commits into
Conversation
4 of 13 tasks
Contributor
|
@SGamrekelashvili Thanks for the PR, but internally we never agreed on moving Animated to a separate package. This work can't be run from the OSS community because there is ton of code internally that depends on Animated classes. Importing this change will break every app we have internally at Meta and it will be a big breaking change for the whole ecosystem, at least for all the people using Animated instead of Reanimated. For this kind of changes, we need to go through a proper communication-deprecation-copy-remove cycle. I'm sorry for the time you invested in this. |
Author
|
@cipolleschi thanks for sharing information 😊 and describing everything |
Contributor
|
Closing this for now as we can't proceed further until we find alignment internally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR is for moving Animated to separate package called @react-native/animated and it will be under packages/animated
as everything is mentioned in #35263
Changelog:
[GENERAL] [CHANGED] Move react-native/Libraries/Animated to @react-native/animated package
Test Plan:
Trimmed-A-.mov