Repository navigation
Remove defaultProps from SegmentedControlIOS #31804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
daschaa
wants to merge
4
commits into
react:master
from
daschaa:fix/31604_segmentedcontrolios_default_props
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
58d5ec1
Remove defaultProps from SegmentedControlIOS
8d7147d
Merge branch 'master' into fix/31604_segmentedcontrolios_default_props
daschaa 32850eb
Move props to SegmentedControlIOS render and add snapshot tests
5e0b5c4
Merge branch 'master' into fix/31604_segmentedcontrolios_default_props
daschaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
Libraries/Components/SegmentedControlIOS/__tests__/SegmentedContolIOS-test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| * | ||
| * @format | ||
| * @emails oncall+react_native | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| const React = require('react'); | ||
| const ReactTestRenderer = require('react-test-renderer'); | ||
|
|
||
| const SegmentedControlIOS = require('../SegmentedControlIOS.ios'); | ||
|
|
||
| describe('SegmentedControlIOS', () => { | ||
| it('renders the segmented control', () => { | ||
| const component = ReactTestRenderer.create(<SegmentedControlIOS />); | ||
| expect(component).not.toBeNull(); | ||
| }); | ||
| it('renders the segmented control with enabled default value', () => { | ||
| const component = ReactTestRenderer.create(<SegmentedControlIOS />); | ||
| expect(component.toTree().rendered.props.enabled).toBe(true); | ||
| expect(component).toMatchSnapshot(); | ||
| }); | ||
| it('renders the segmented control with enabled', () => { | ||
| const component = ReactTestRenderer.create( | ||
| <SegmentedControlIOS enabled={true} />, | ||
| ); | ||
| expect(component.toTree().rendered.props.enabled).toBe(true); | ||
| expect(component).toMatchSnapshot(); | ||
| }); | ||
| it('renders the segmented control with enabled set to false', () => { | ||
| const component = ReactTestRenderer.create( | ||
| <SegmentedControlIOS enabled={false} />, | ||
| ); | ||
| expect(component.toTree().rendered.props.enabled).toBe(false); | ||
| expect(component).toMatchSnapshot(); | ||
| }); | ||
| it('renders the segmented control with values default value', () => { | ||
| const component = ReactTestRenderer.create(<SegmentedControlIOS />); | ||
| expect(component.toTree().rendered.props.values).toEqual([]); | ||
| expect(component).toMatchSnapshot(); | ||
| }); | ||
| it('renders the segmented control with values', () => { | ||
| const values = ['One', 'Two']; | ||
| const component = ReactTestRenderer.create( | ||
| <SegmentedControlIOS values={values} />, | ||
| ); | ||
| expect(component.toTree().rendered.props.values).toBe(values); | ||
| expect(component).toMatchSnapshot(); | ||
| }); | ||
| }); | ||
86 changes: 86 additions & 0 deletions
86
...es/Components/SegmentedControlIOS/__tests__/__snapshots__/SegmentedContolIOS-test.js.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[`SegmentedControlIOS renders the segmented control with enabled 1`] = ` | ||
| <RCTSegmentedControl | ||
| enabled={true} | ||
| onChange={[Function]} | ||
| style={ | ||
| Array [ | ||
| Object { | ||
| "height": 28, | ||
| }, | ||
| undefined, | ||
| ] | ||
| } | ||
| values={Array []} | ||
| /> | ||
| `; | ||
|
|
||
| exports[`SegmentedControlIOS renders the segmented control with enabled default value 1`] = ` | ||
| <RCTSegmentedControl | ||
| enabled={true} | ||
| onChange={[Function]} | ||
| style={ | ||
| Array [ | ||
| Object { | ||
| "height": 28, | ||
| }, | ||
| undefined, | ||
| ] | ||
| } | ||
| values={Array []} | ||
| /> | ||
| `; | ||
|
|
||
| exports[`SegmentedControlIOS renders the segmented control with enabled set to false 1`] = ` | ||
| <RCTSegmentedControl | ||
| enabled={false} | ||
| onChange={[Function]} | ||
| style={ | ||
| Array [ | ||
| Object { | ||
| "height": 28, | ||
| }, | ||
| undefined, | ||
| ] | ||
| } | ||
| values={Array []} | ||
| /> | ||
| `; | ||
|
|
||
| exports[`SegmentedControlIOS renders the segmented control with values 1`] = ` | ||
| <RCTSegmentedControl | ||
| enabled={true} | ||
| onChange={[Function]} | ||
| style={ | ||
| Array [ | ||
| Object { | ||
| "height": 28, | ||
| }, | ||
| undefined, | ||
| ] | ||
| } | ||
| values={ | ||
| Array [ | ||
| "One", | ||
| "Two", | ||
| ] | ||
| } | ||
| /> | ||
| `; | ||
|
|
||
| exports[`SegmentedControlIOS renders the segmented control with values default value 1`] = ` | ||
| <RCTSegmentedControl | ||
| enabled={true} | ||
| onChange={[Function]} | ||
| style={ | ||
| Array [ | ||
| Object { | ||
| "height": 28, | ||
| }, | ||
| undefined, | ||
| ] | ||
| } | ||
| values={Array []} | ||
| /> | ||
| `; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.