Repository navigation
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Excellent! |
|
Looks good! We're currently working in the process of moving the packager to it's own github repo and we'll be able to accept contributions like this much faster (we can just use the Github merge button). I'm hoping we can release it some time this week, and I'll ping so we can move the PR there. |
|
please merge this! |
|
@pickhardt This looks good to me. Can you please rebase? |
|
Isn't the packager going to move to a new repo, so this pull request doesn't matter here any longer? |
|
i guess when they move package into another repo they can move it along with the patch |
|
@pickhardt i think this patch doesn't work anymore. i tried to reproduce it locally by patching files in works perfectly with plain |
|
Yeah it says the branch has conflicts that must be resolved. I'm not sure what they are - the file changed looks pretty straightforward to me. Honestly it's not that important to me any longer, I switched to using .js files. The main reason I wanted .jsx had to do with my text editor's code styling, but that isn't a problem anymore. |
|
Would love to see this rebased and merged! |
|
This would be awesome! Please merge. |
|
Still waiting for this merge. |
|
@pickhardt - looks like the new home for this is here: https://github.com/exponentjs/react-native/blob/8d8da11010e478bb08c2298f9512965f1ee21037/packager/react-packager/src/DependencyResolver/DependencyGraph/index.js#L57 @jonaswindey @natorojr @hojberg @pickhardt - if any of you are interested in this please submit a new PR and I can merge this quickly now that I have ability to land any type of PR :) |
See also #2303