Skip to content

Use jsx files in the dependencies and the watchers - #2305

Closed
pickhardt wants to merge 2 commits into
react:masterfrom
pickhardt:master
Closed

pickhardt wants to merge 2 commits into
react:masterfrom
pickhardt:master

Conversation

@pickhardt

Copy link
Copy Markdown

See also #2303

@facebook-github-bot

Copy link
Copy Markdown
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@jaygarcia

Copy link
Copy Markdown
Contributor

Excellent!

@amasad

amasad commented Sep 8, 2015

Copy link
Copy Markdown
Contributor

Looks good! We're currently working in the process of moving the packager to it's own github repo and we'll be able to accept contributions like this much faster (we can just use the Github merge button). I'm hoping we can release it some time this week, and I'll ping so we can move the PR there.

@kaievns

kaievns commented Oct 10, 2015

Copy link
Copy Markdown

please merge this!

@ide

ide commented Oct 10, 2015

Copy link
Copy Markdown
Contributor

@pickhardt This looks good to me. Can you please rebase?

@pickhardt

Copy link
Copy Markdown
Author

Isn't the packager going to move to a new repo, so this pull request doesn't matter here any longer?

@kaievns

kaievns commented Oct 12, 2015

Copy link
Copy Markdown

i guess when they move package into another repo they can move it along with the patch

@kaievns

kaievns commented Oct 13, 2015

Copy link
Copy Markdown

@pickhardt i think this patch doesn't work anymore. i tried to reproduce it locally by patching files in node_modules manually, and it keeps throwing errors like that

Unable to resolve module ./components/search_bar from /[filtered]/src/app.ios.js

works perfectly with plain .js files. is there any way i can debug it?

@pickhardt

Copy link
Copy Markdown
Author

Yeah it says the branch has conflicts that must be resolved. I'm not sure what they are - the file changed looks pretty straightforward to me. Honestly it's not that important to me any longer, I switched to using .js files. The main reason I wanted .jsx had to do with my text editor's code styling, but that isn't a problem anymore.

@hojberg

hojberg commented Oct 23, 2015

Copy link
Copy Markdown

Would love to see this rebased and merged!

@natorojr

Copy link
Copy Markdown

This would be awesome! Please merge.

@jonaswindey

Copy link
Copy Markdown

Still waiting for this merge.

@brentvatne

Copy link
Copy Markdown
Collaborator

@pickhardt - looks like the new home for this is here: https://github.com/exponentjs/react-native/blob/8d8da11010e478bb08c2298f9512965f1ee21037/packager/react-packager/src/DependencyResolver/DependencyGraph/index.js#L57

@jonaswindey @natorojr @hojberg @pickhardt - if any of you are interested in this please submit a new PR and I can merge this quickly now that I have ability to land any type of PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants