Repository navigation
[TimerMixin] Removing TimerMixin on TextInput - #21522
richardcann wants to merge 2 commits into
Conversation
facebook-github-bot
added
the
CLA Signed
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
flowfound some issues.
| @@ -858,6 +858,9 @@ const TextInput = createReactClass({ | |||
There was a problem hiding this comment.
Cannot call cancelAnimationFrame with this._rafId bound to requestId because null or undefined [1] is incompatible with AnimationFrameID [2].
react-native-bot
added
Component: TextInput
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
RSNara
changed the title
facebook-github-bot
added
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
@rmcp1g15 merged commit 31d6a69 into |
Summary: Related to react#21485. Removed TimerMixin from Libraries/Components/TextInput/TextInput.js Pull Request resolved: react#21522 Differential Revision: D10229669 Pulled By: RSNara fbshipit-source-id: 45de331203eddce06b8fb7ddf4080869c07b6c55
Related to #21485.
Removed TimerMixin from Libraries/Components/TextInput/TextInput.js
Test Plan:
RNTester:
Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/Components/TextInput/TextInput.js] - remove TimerMixin