Repository navigation
Conversation
facebook-github-bot
added
the
CLA Signed
RSNara
approved these changes
Oct 5, 2018
RSNara
left a comment
RSNara
left a comment
Contributor
There was a problem hiding this comment.
I think this test was disabled a while ago in our CI. Before I land this code, I'll try to run this test locally. Thanks for the PR! 😀
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
changed the title
Collaborator
|
@peaonunes merged commit 4d69431 into |
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related to react#21485. Removed `TimerMixin` from `ReactContentSizeUpdateTest`. Pull Request resolved: react#21502 Reviewed By: TheSavior Differential Revision: D10218548 Pulled By: RSNara fbshipit-source-id: 9a0642e14f8548d8dc9683f0f70353416ed04ae0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #21485.
Removed
TimerMixinfromReactContentSizeUpdateTest.Test Plan:
I am still not sure on how test this change since the change was made on
ReactContentSizeUpdateTestwhich is aIntegrationTest.The file is referenced at
IntegrationTests/RCTRootViewIntegrationTestApp.jsandRNTester/RNTesterIntegrationTests/RCTRootViewIntegrationTests.mwhich seems to be some kind of suit of tests, but I have not found any run instructions for that. I am thinking about on how to guarantee that the test is correct since it might pass now, but not really testing what it was supposed to test, etc.Who do we test the 'tester' ? haha.
It would be nice to have some guidance here.
On the other hand, I've made sure to run:
All done with no errors =]
Release Notes:
[GENERAL] [ENHANCEMENT] [IntegrationTests/ReactContentSizeUpdateTest.js] - Remove TimerMixin in favor of TimeoutID and controlled timeout