Repository navigation
Conversation
facebook-github-bot
added
the
CLA Signed
Thomas0c
changed the title
facebook-github-bot
left a comment
facebook-github-bot
left a comment
Contributor
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
changed the title
facebook-github-bot
added
the
Import Started
Collaborator
hramos
removed
Import Started
rozele
pushed a commit
to microsoft/react-native-windows
that referenced
this pull request
Apr 14, 2019
Summary: Related to #21485. Removed `TimerMixin` from the `TouchableWithoutFeedback` component since it is currently not used. Added tests cases for `TouchableWithoutFeedback` to check for any runtime issues. Pull Request resolved: react/react-native#21493 Differential Revision: D10219098 Pulled By: RSNara fbshipit-source-id: d9517b2bd5b72b0450fa864f3556673ae3181552
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related to react#21485. Removed `TimerMixin` from the `TouchableWithoutFeedback` component since it is currently not used. Added tests cases for `TouchableWithoutFeedback` to check for any runtime issues. Pull Request resolved: react#21493 Differential Revision: D10219098 Pulled By: RSNara fbshipit-source-id: d9517b2bd5b72b0450fa864f3556673ae3181552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #21485.
Removed
TimerMixinfrom theTouchableWithoutFeedbackcomponent since it is currently not used.Added tests cases for
TouchableWithoutFeedbackto check for any runtime issues.Test Plan:
Ran:
Additionally ran the following scripts with no errors:
Following the removal of
TimerMixin, theTouchableWithoutFeedbackcomponent has been tested during runtime usingRNTesterto surface any runtime issues. The change was tested on both iOS and Android with no obvious errors.RNTester steps:
RNTester.“<Touchable*> and onPress”<TouchableWithoutFeedback />works as expected:General behavior for
TouchableWithoutFeedback:Added tests for
disabledstate forTouchableWithoutFeedbackto mirror tests for otherTouchable*types:Release Notes:
[GENERAL] [ENHANCEMENT] [Libraries/Components/Touchable/TouchableWithoutFeedback.js] - remove TimerMixin dependency
[GENERAL] [ENHANCEMENT] [RNTester/js/TouchableExample.js] - Add TouchableWithoutFeedback test cases.