[formatlos]

I added troubleshooting docs for connection to the development server from device, otherwise it's maybe hard to find out why it's not working.

Due to a disparity in what GitHub's API return the original PR (#14885) couldn't get imported, so I created a new PR as @hramos suggested.

[pull-bot]

📄 Thanks for your contribution to the docs!

Attention: @facebook/react-native

Generated by 🚫 dangerJS

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[formatlos]

still not working?

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[formatlos]

@hramos do you have any clue why the build fails?

As far as I can see the build fails because of a flow version mismatch.

Wrong version of Flow. The config specifies version ^0.49.1 but this is version 0.51.1

.flowconfig and package.jsonboth point to 0.51.1. the only place I could find ^0.49.1 was local-cli/templates/HelloWorld/_flowconfig

This seems to be a general issue with your CI-setup and should also occur on other PRs. As I only touched docs the tests should still run as expected. Just to be sure I also ran all the test locally which went fine.

[formatlos]

just looked at some other recent PRs they also fail with the same error

[hramos]

It's timing out. It's not due to any problem with the PR itself.

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hramos]

@formatlos the time out is due to a linter check we perform on images prior to import. The proper long term fix is for us to address this issue on our side; short term, we could try replacing the screengrab with a smaller file size-wise.

[formatlos]

@hramos sure no problem, what's the maximum file-size allowed?

[hramos]

There's no definite file size limit. The import process as one of the lints, checks the PNG to make sure it is optimized. This appears to be taking long enough to make the whole process time out.

We perform this check to make sure images in the RN core itself are optimized. In this case, we really don't need to lint this image as we don't necessarily care about it being optimized for use in the website. That's the long-term fix - to exclude the website directory from this check, which is something I need to look into.

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[hramos]

Don't worry about updating the PR just yet. If this latest import fails, I can still get your commits in manually. I'm really sorry this has been so painful! The issue that blocked your original PR is unrelated to this, you just happened to unluckily hit two issues in a row. I'll get this merged soon.