Repository navigation
Modal shouldn't cover the Element inspector #8193
Description
When the Element inspector is shown and a <Modal> is rendered at the same time, the Modal covers the Element inspector. This shouldn't be the case :)
Experience required: JS.
Activity
Ehesp commentedon Jun 17, 2016
The modal covers everything for me, can't even access the dev menu.
frantic commentedon Jun 17, 2016
We've fixed this internally, should be a trivial fix in OSS. The idea is to wrap the content of the modal into
<AppContainer>that provides all development level tools – inspector, yellow box, etc.mkonicek commentedon Jun 17, 2016
@frantic Oh cool, so the Modal effectively renders the YellowBox and the Modal's children:
https://github.com/facebook/react-native/blob/master/Libraries/ReactIOS/AppContainer.js
mkonicek commentedon Jun 17, 2016
@Ehesp I created a separate issue for this: #8187. The trick with
AppContainermight not be enough for the dev menu being behind Modal. We might need changes in native for that one (at least on Android).mkonicek commentedon Jun 23, 2016
@frantic Can you explain this a bit more please? Did you mean
<Modal>should render an<AppContainer>by default?BilalBudhani commentedon Jun 24, 2016
@frantic I'm looking into this issue as well. It would be great if you can explain a bit more.
aakashsigdel commentedon Aug 11, 2016
@mkonicek as mentioned by @frantic, wrapping the contains of the modal in AppContainer does seem to solve the problem. Could you please tell me what is the status on this issue? Should I open a PR for this?
satya164 commentedon Aug 11, 2016
@aakashsigdel Yeah, would be cool if you can send a PR.
aakashsigdel commentedon Aug 12, 2016
@satya164 I tried to include the master branch as dependency in my project, but it fails with
"Requiring unknown module "react/lib/ReactPropTypesSecret".I followed the guide from the docs:
Building React Native from sourcehttps://facebook.github.io/react-native/docs/android-building-from-source.html
Is there something I am missing?
christopherdro commentedon Nov 25, 2016
Fixed via 05de4db