Repository navigation
[0.23.0-rc1] Cannot resolve react-native #6640
Description
On mac, npm v.3.8.2, node 5.3.0:
On a fresh install:
npm i --save react react-native@next
The install seems to complete successfully.
npm ls --depth=0
rn@1.0.0 /Users/ianvs/code/experiments/rn
├── react@0.14.7
└── react-native@0.23.0-rc1
But:
npm ls react
rn@1.0.0 /Users/ianvs/code/experiments/rn
└── react@0.14.7
npm ls react-native
rn@1.0.0 /Users/ianvs/code/experiments/rn
└── (empty)
npm ERR! code 1
This is causing problems in some third party libraries I use which import RN with var React = require('react-native);`.
I had no trouble with 0.22.2.
Activity
[-][0.23.0-rc1] NPM cannot resolve react-native[/-][+][0.23.0-rc1] Cannot resolve react-native[/+]tyao1 commentedon Mar 25, 2016
Same here. After upgrading to 0.23-rc1, on android, a third party module throws unable to resolve module Subscribable. Everything works on iOS, and works on 0.22.2 and before.
rogchap commentedon Mar 25, 2016
Do you have Hot Reloading Enabled? I had this issue and switching off Hot Reloading "solved" it.
brentvatne commentedon Mar 26, 2016
I had the same issue with HMR enabled @rogchap
@cpojer -- @skevy thought this might be a node-haste bug
IanVS commentedon Mar 28, 2016
Surprisingly yes, disabling hot reloading did prevent the redboxes (both Android and iOS). Is the
npm lsbehavior a red herring?cpojer commentedon Mar 28, 2016
cc @martinbigio
martinbigio commentedon Mar 28, 2016
Hmm I cannot repro neither on master nor @next. Doesn't make sense that this repro only with HMR enabled. @brentvatne, @IanVS could you guys try reseting the packagers cache?
@satya164, have you seen this issue?
IanVS commentedon Mar 28, 2016
I used
npm start -- --clear-cachewith no change in behavior.martinbigio commentedon Mar 28, 2016
@IanVS you should run
npm start -- --reset-cache(reset-cacheinstead ofclear-cache).IanVS commentedon Mar 28, 2016
No luck. I'll try to create a minimal reproduction.
IanVS commentedon Mar 28, 2016
I can reproduce on a clean install with:
Add the following to the top of
index.ios.js:Starting it up should work fine, getting the default "Welcome to React Native!" screen.
But, if you enable hot reloading, you should see a redbox similar to the one I posted above.
martinbigio commentedon Mar 28, 2016
Thanks @IanVS, I can repro following your steps.
The require on the HMR path happens here: https://github.com/facebook/react-native/blob/3a1634ec7b0dfa2b5d8890118565006d845e2039/babel-preset/configs/hmr.js#L28.
Not sure why this broke but changing React for react-native should be equivalent and it works. Will submit PR and publish a new version of the preset soon.
satya164 commentedon Mar 29, 2016
Only happens when you install some other pacakge? Weird.
Use `react-native` instead of `React` on hmr config
martinbigio commentedon Mar 30, 2016
Should work now that we have released babel-preset-react-native@1.5.5. You'll have to upgrade from 1.5.4 to 1.5.5
Use `react-native` instead of `React` on hmr config
Use `react-native` instead of `React` on hmr config