Skip to content

com.facebook.react:react-native:0.19.0 @ReactProp issue on android #5649

Closed

Description

@soxunyi

If you use android native view, and annotations ReactProp. Please import the right ReactProp class, import com.facebook.react.uimanager.annotations.ReactProp, rather than import com.facebook.react.uimanager.ReactProp.

com.facebook.react.uimanager.ReactProp is not work on 0.19.0.

Why do not remove this class on 0.19.0?

Activity

  1. facebook-github-bot commented on Jan 31, 2016

    @facebook-github-bot
    Contributor

    Hey soxunyi, thanks for reporting this issue!

    React Native, as you've probably heard, is getting really popular and truth is we're getting a bit overwhelmed by the activity surrounding it. There are just too many issues for us to manage properly.

    • If you don't know how to do something or something is not working as you expect but not sure it's a bug, please ask on StackOverflow with the tag react-native or for more real time interactions, ask on Discord in the #react-native channel.
    • If this is a feature request or a bug that you would like to be fixed, please report it on Product Pains. It has a ranking feature that lets us focus on the most important issues the community is experiencing.
    • We welcome clear issues and PRs that are ready for in-depth discussion. Please provide screenshots where appropriate and always mention the version of React Native you're using. Thank you for your contributions!
  2. rpopovici commented on Feb 2, 2016

    @rpopovici

    temporary fix for this is to add the following to your build.gradle

    android {
    ...
    lintOptions {
    warning 'InvalidPackage'
    }
    }

    dependencies {
    ...
    compile 'com.facebook.react:react-native:0.19.+'
    }

    and then import com.facebook.react.uimanager.annotations.ReactProp

  3. deminoth commented on Feb 17, 2016

    @deminoth
    Contributor

    +1. import com.facebook.react.uimanager.ReactProp does not showing any error but not working. We should notify using import com.facebook.react.uimanager.annotations.ReactProp to developer.

  4. janicduplessis commented on Mar 20, 2016

    @janicduplessis
    Contributor

    This was a breaking change in 0.19, sorry if it was not communicated properly.

  5. janicduplessis commented on Mar 20, 2016

    @janicduplessis
    Contributor
  6. facebook-github-bot commented on Mar 20, 2016

    @facebook-github-bot
    Contributor

    Closing this issue as @janicduplessis says the question asked has been answered. Please help us by asking questions on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only.

  7. taypo commented on Apr 4, 2016

    @taypo

    Lost two days on this. Please make a remark on the documentation.

  8. fiattt commented on May 6, 2016

    @fiattt

    Lost one days on this - -!

  9. added a commit that references this issue on Sep 5, 2016
  10. locked as resolved and limited conversation to collaborators on May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Ran CommandsOne of our bots successfully processed a command.Resolution: LockedThis issue was locked by the bot.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions