Skip to content

[android] upgrade to latest okhttp version #4021

Closed

Description

@jaredly

2.5.0 was released in August, superceding 2.4.0 (which react-native depends on) which was released in May
Is this as simple as a change to the gradle deps file? As a point release, it shouldn't™ be backwards incompatible

Activity

  1. ide commented on Nov 9, 2015

    @ide
    Contributor

    cc @kmagiera (and @mkonicek if you're not on PTO yet)

  2. kmagiera commented on Nov 10, 2015

    @kmagiera
    Contributor

    Thanks for reporting, I've upgraded gradle config in caf111e

  3. christopherdro commented on Feb 17, 2016

    @christopherdro
    Contributor

    Update:
    Looks like 3.1.2 is the latest stable release. Also, they changed the maven group to okttp3 to reflect the new version. See: lysine-dev/okhttp#2118

    @kmagiera Thoughts on upgrading? Seems like there have been a good amount of improvements made. https://github.com/square/okhttp/blob/master/CHANGELOG.md

  4. AndrewJack commented on Feb 24, 2016

    @AndrewJack
    Contributor

    Started some work to upgrade to v3. However the Facebook team had some concerns.

    • Updating to v3 will bloat apps still using OkHttp 2 (Problem may reverse in a few months)
    • Updating to 2.7.4 would break for anyone relying on 2.5 or earlier - due to some web socket API changes in 2.6.
    • The package name change between v2 and v3 helps by not breaking existing versions of OkHttp 2
  5. aoriani commented on Mar 7, 2016

    @aoriani

    A concern that I have is that React-Native imposes a certain version of OkHttp to the hosting app. That is particularly bad for existing apps that are already using OkHttp and want to use React-Native to implement some new functionality. In my particular case we use OkHttp 2.7.4 whereas React-Native 0.20 uses 2.5.0. As noticed above there's some incompatibility between those two OkHttp 2.x versions.

    One could say that I could just downgrade to 2.5. and be happy, but that is not desirable. Most of the features of my app rely on network, making OkHttp a vital library for our app. And as such, it is very important that I should be able to pick its version. If some critical bug or security is found, I want to be able to quickly upgrade OkHttp. However in the current situation I am tied to whatever version is defined by React-Native.

    Is there any plans to solve the strict version dependency to OkHttp or to a particular network library?. I would think that people using pure Volley would not like to add a new networking library to bloat their APK. That could be a barrier to for existing apps to adopt React-Native.

  6. ghost added a commit that references this issue on May 17, 2016
  7. added a commit that references this issue on Jun 18, 2016
  8. mkonicek commented on Jul 29, 2016

    @mkonicek
    Contributor

    Hi there! This issue is being closed because it has been inactive for a while.

    But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/android-upgrade-to-latest-okhttp-version

    ProductPains helps the community prioritize the most important issues thanks to its voting feature.
    It is easy to use - just login with GitHub. GitHub issues have voting too, nevertheless
    Product Pains has been very useful in highlighting the top bugs and feature requests:
    https://productpains.com/product/react-native?tab=top

    Also, if this issue is a bug, please consider sending a pull request with a fix.
    We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

  9. locked as resolved and limited conversation to collaborators on Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions