Repository navigation
Android - Linking won't openURL with uppercase in protocol http/https #21395
Description
- [v] Review the documentation: https://facebook.github.io/react-native
- [v] Search for existing issues: https://github.com/facebook/react-native/issues
- [not sure] Use the latest React Native release: https://github.com/facebook/react-native/releases
Environment
Environment:
OS: macOS High Sierra 10.13.6
Node: 8.12.0
Yarn: 1.10.1
npm: 6.4.1
Watchman: Not Found
Xcode: Xcode 10.0 Build version 10A255
Android Studio: 3.1 AI-173.4907809
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.53.0 => 0.53.0
Run react-native info in your terminal and paste its contents here.
https://snack.expo.io/@hyunjongl/android-linking-protocol-problem
Expo can be used to reproduce.
Description
Describe your issue in detail. Include screenshots if needed. If this is a regression, let us know.
https://snack.expo.io/@hyunjongl/android-linking-protocol-problem
The Android Intent can't open URL with uppercase in http/https. However iOS can open it.
Reproducible Demo
https://snack.expo.io/@hyunjongl/android-linking-protocol-problem
Run with Android. You won't open urls with uppercase in the protocol of http/https.
Let us know how to reproduce the issue. Include a code sample, share a project, or share an app that reproduces the issue using https://snack.expo.io/. Please follow the guidelines for providing a MCVE: https://stackoverflow.com/help/mcve
Activity
hyunjongL commentedon Sep 28, 2018
#21396
Just created a PR for it with few lines added.
I want to see if anyone found this a bit disturbing too!
react-native-bot commentedon Sep 28, 2018
Can you run
react-native infoand edit your issue to include these results under the Environment section?If you believe this information is irrelevant to the reported issue, you may write
[skip envinfo]under Environment to let us know.react-native-bot commentedon Sep 28, 2018
It looks like you are using an older version of React Native. Please update to the latest release, v0.57 and verify if the issue still exists.
The ":rewind:Old Version" label will be removed automatically once you edit your original post with the results of running
react-native infoon a project using the latest release.hyunjongL commentedon Sep 29, 2018
Merged!
hyunjongL commentedon Oct 1, 2018
@RSNara
Okay my PR is merged, but I found out that in some android phones, startsWith does not work as intended. Should it be changed to
indexOf()===0
or is it fine to be left as startsWith?
My android phone (Android version 7.0) does not support startsWith.
hyunjongL commentedon Oct 1, 2018
#11370
stale commentedon Dec 30, 2018
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.
stale commentedon Jan 6, 2019
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.