Skip to content

0.4.x - breaking changes? #1089

Closed
Closed

Description

@voronianski

I didn't make any progress with react-native for several weeks and the last version that I used was 0.3.11 which worked perfectly.

Unfortunately after update to 0.4.1 I have several issues. Official blog post doesn't say anything about breaking changes etc. - http://facebook.github.io/react/blog/2015/04/17/react-native-v0.4.html

Styles are broken

That's what I have right now (before update it worked as fullscreen):

Code is pretty straightforward - https://github.com/voronianski/EightTracksReactNative/blob/master/index.ios.js#L74

Build empty screen

One more strange issue is happening with this demo app - https://github.com/voronianski/react-native-effects-view/tree/master/example/EffectsApp

After update it renders white screen in simulator.. Didn't have time to figure out what is going.

Activity

  1. romanonthego commented on May 1, 2015

    @romanonthego

    I believe it is 0.4.1 not 0.4.0 - i've updated my up to 0.4.0 without problem while 0.4.1 break something in styling (particulary in top navbars - but i'm using https://github.com/Kureev/react-native-navbar so i'm not sure where collision is happening).
    Anyway, you may consider to rollback to 0.4.0 - this could work.

  2. nicklockwood commented on May 1, 2015

    @nicklockwood
    Contributor

    I've checked on our latest codebase and this seems to be working correctly. Sorry for the breakage, but it should be fixed in the next update.

  3. lelandrichardson commented on May 1, 2015

    @lelandrichardson
    Contributor

    Just to provide additional data points, this broke some similar styles in my app as well... I've reverted back to 0.4.0

  4. bimawa commented on May 6, 2015

    @bimawa
    Contributor

    Its similar trouble #1051 ?

  5. lelandrichardson commented on May 6, 2015

    @lelandrichardson
    Contributor

    @bimawa that was indeed the issue for me...

    adding width: undefined, height: undefined to the styles applied to the image fixed it in my case.

  6. bimawa commented on May 7, 2015

    @bimawa
    Contributor

    @lelandrichardson Waaahh It's helped for me Thx!!

  7. locked as resolved and limited conversation to collaborators on May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions