Repository navigation
Upgrade to Jest 26 - #8955
Merged
Merged
Upgrade to Jest 26#8955
Conversation
Contributor
Author
|
Running into issues on Node 10.20.1 when running Jest. While running in debug it's choking here: https://github.com/jsdom/jsdom/blob/8921128ee1efe6737e3ea200959eb01fe75ff3aa/lib/jsdom/browser/Window.js#L51, as Looks to be the same issue somebody else mentioned in the jsdom issues: jsdom/jsdom#2795 (comment) I've created an issue in the jsdom repo to track this. |
commented
May 29, 2020
Contributor
|
🎉 |
ianschmitz
marked this pull request as ready for review
May 29, 2020 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8954.
We can ship the TypeScript template referencing
@types/jest@25until the 26 version drops. There should only be minor differences that we can call out in our release notes. From Simen:Still todo:
@types/jestin the TypeScript template. We may require TypeScript 3.8: chore: require minimum typescript@3.8 jestjs/jest#9823. Need to sync with Simen to figure out the detailscc @SimenB.