Repository navigation
Conversation
ghost
added
the 
vjeux
reviewed
Sep 26, 2016
| lastOnOverlayDivReady(overlayDiv); | ||
| }); | ||
|
|
||
| // Zalgo alert: onIframeLoad() will be called either synchronouly |
Contributor
There was a problem hiding this comment.
I ran into this issue when trying to setup dom measurement for css-layout browser testing. This was super annoying :)
feiqitian
pushed a commit
to feiqitian/create-react-app
that referenced
this pull request
Oct 25, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out, loading empty iframes is sync in some browsers, and async in others.
Fixes #747.
I also added some code to print errors to the console and clear outdated ones so they don’t distract in the console.