Skip to content

Run ForkTsCheckerWebpackPlugin with async when CI env is used - #6209

Closed
insidewhy wants to merge 1 commit into
react:masterfrom
insidewhy:jp/fix-5820
Closed

insidewhy wants to merge 1 commit into
react:masterfrom
insidewhy:jp/fix-5820

Conversation

@insidewhy

@insidewhy insidewhy commented Jan 15, 2019 •

Copy link
Copy Markdown

See #5820

To briefly summarise: ForkTsCheckerWebpackPlugin is run with async: false due to screen clearing issues hiding console errors, the unfortunate side-effect being that the recompilations take several seconds instead of less than 300ms.

When the CI environment variable is set the screen is not cleared so the "errors being hidden" issue cannot be present. In that case async can be set to true to have much faster compilation times. Then users who wish to use typescript and would prefer to have their development experience be drastically faster and won't mind the screen not being cleared can simply set CI in their package.json.

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@ianschmitz

Copy link
Copy Markdown
Contributor

This sounds like a dupe of #5903?

@insidewhy

Copy link
Copy Markdown
Author

@ianschmitz Cool #5903 looks like a better way to do this, I may as well close this.

@insidewhy insidewhy closed this Jan 15, 2019
@lock lock Bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants