Skip to content

Generate html-manifest.json of html assets. - #5955

Closed
patope wants to merge 3 commits into
react:masterfrom
patope:generate-html-manifest
Closed

patope wants to merge 3 commits into
react:masterfrom
patope:generate-html-manifest

Conversation

@patope

@patope patope commented Dec 3, 2018

Copy link
Copy Markdown

It's non-trivial to reconstruct html page using asset-manifest.json currently. See: #5513

This change adds alternative asset file for that purpose. ExtractHtmlManifestPlugin extracts html page assets as defined here https://github.com/jantimon/html-webpack-plugin/blob/master/lib/hooks.js#L21 to separate file html-manifest.json. This file can be used to reconstruct html page.

example of generate html-manifest.json:

{
  "publicPath": "/",
  "js": [
    "/static/js/runtime~main.229c360f.js",
    "/static/js/1.82dafdb5.chunk.js",
    "/static/js/main.c9b66095.chunk.js"
  ],
  "css": [
    "/static/css/main.90a4e9dc.chunk.css"
  ]
}

@netlify

netlify Bot commented Dec 3, 2018 •

Copy link
Copy Markdown

Deploy preview for gallant-davinci-8f9bd9 ready!

Built with commit df2f0ed

https://deploy-preview-5955--gallant-davinci-8f9bd9.netlify.com

@facebook-github-bot

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@patope patope changed the title WIP: Generate html-manifest.json of html assets. Generate html-manifest.json of html assets. Dec 3, 2018
@stale

stale Bot commented Jan 6, 2019

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale Bot added the stale label Jan 6, 2019
@stale

stale Bot commented Jan 12, 2019

Copy link
Copy Markdown

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@bartlangelaan

Copy link
Copy Markdown

Shouldn't be stale.

Something like this is really useful for people that want to integrate CRA in another application.

Please open again, or provide feedback 😁

@evang522

evang522 commented Jan 17, 2019 •

Copy link
Copy Markdown

We are also needing this in order to construct an HTML file dynamically outside of the react environment. This is a huge step towards making CRA compatible with multiple different environments. Please reopen!

@lock lock Bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants