Skip to content

Fix —info clipboard usage, envinfo no longer supports clipboard option - #5911

Closed
tabrindle wants to merge 1 commit into
react:masterfrom
tabrindle:envinfo-clipboard
Closed

tabrindle wants to merge 1 commit into
react:masterfrom
tabrindle:envinfo-clipboard

Conversation

@tabrindle

Copy link
Copy Markdown
Contributor

In an effort to fix --info on windows, a previous PR removed the auto copy to clipboard feature.

This adds it back using the same library envinfo previously used.

@iansu

iansu commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

Will this work on Windows now?

@tabrindle

Copy link
Copy Markdown
Contributor Author

It should as it is installed normally, and clipboardy does support windows - although I don't have a good way to confirm this right now.

@Timer

Timer commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

I think we'd rather just let this print out for the time being. There's been too many issues.

@iansu

iansu commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

I kind of agree. Especially if this means we're now going to be installing a package with native extensions. Given how often that stuff breaks, especially around new Node releases, it seems risky.

@tabrindle

Copy link
Copy Markdown
Contributor Author

Fine with me, this is after all why I removed it from my library.

@tabrindle tabrindle closed this Nov 27, 2018
@Timer

Timer commented Nov 28, 2018

Copy link
Copy Markdown
Contributor

Thanks for always being on top of these issues, @tabrindle!

@lock lock Bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants