Skip to content

Feed correct line number to gvim on launch - #5202

Merged
gaearon merged 1 commit into
react:masterfrom
identor:master
Oct 1, 2018
Merged

gaearon merged 1 commit into
react:masterfrom
identor:master

Conversation

@identor

@identor identor commented Oct 1, 2018

Copy link
Copy Markdown
Contributor

Clicking Error overlay should feed the correct line number for gvim.

Relates to #2636.

@Timer

Timer commented Oct 1, 2018 •

Copy link
Copy Markdown
Contributor

Does it need added to COMMON_EDITORS_LINUX and potentially isTerminalEditor?

@Timer Timer modified the milestones: 2.0.x, 2.x Oct 1, 2018
@identor

identor commented Oct 1, 2018

Copy link
Copy Markdown
Contributor Author

Hi @Timer ,

Have tested this, successfully able to go to the line number without adding it to COMMON_EDITORS_LINUX.

But might as well add it since I'm referencing: #2636

@Timer

Timer commented Oct 1, 2018 •

Copy link
Copy Markdown
Contributor

It should be able to launch without you specifying it via the EDITOR variable. Can you test this case please?

@identor

identor commented Oct 1, 2018

Copy link
Copy Markdown
Contributor Author

Testing launch without specifying EDITOR variable. I'll update this pull request once done.

Clicking Error overlay should feed the correct line number for gvim.

Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running.

Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM

Relates to react#2636.
@identor

identor commented Oct 1, 2018

Copy link
Copy Markdown
Contributor Author

Added gvim in COMMON_EDITORS_LINUX, launches new gvim when it is running.

Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM

@gaearon
gaearon merged commit bf5a4bf into react:master Oct 1, 2018
@gaearon

gaearon commented Oct 1, 2018

Copy link
Copy Markdown
Contributor

Thanks

@gaearon gaearon modified the milestones: 2.x, 2.0 Oct 1, 2018
@lock lock Bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants