Repository navigation
Conversation
|
@LinusU if I understand the motivation here it's about performance only right? In CRA v5 we have enabled incremental builds setting for the forkTypeCheckerPlugin - not sure if it solves the performance issue you are facing? (The motivation for disabling Eslint was maybe not so much about performance as about BYO eslint setup afaik) |
|
@raix my use case is really that I'm already running the type checker in my editor and I would prefer to not get any errors from type checking whilst editing. In addition to that I'm having performance problems where my editor (VS Code) is super slow to provide type checking and autocomplete suggestions without the flag that I introduced in this PR. I'm not sure if this is actually CPU bound, or if there is some cache or other file-lock that make them compete with each other. If you want to try this out, my project is here: https://github.com/LinusU/beer-recipe-editor Running (Is there any documentation for version 5 available?) |
|
@LinusU we just released v5 - let me know if still suffering from performance issue |
Fixes #5784
This patch adds an additional environment flag:
DISABLE_TSC_PLUGIN. When set totrueit will skip type checking the code using the TypeScript compiler (viafork-ts-checker-webpack-plugin).It was modeled to follow how
DISABLE_ESLINT_PLUGINwork:ESLINT_NO_DEV_ERRORSTSC_COMPILE_ON_ERRORDISABLE_ESLINT_PLUGINDISABLE_TSC_PLUGINThis is useful because some libraries that (ab?)uses the TypeScript type system can cause significant CPU usage. While I love that those libraries can bring type safety to very dynamic problems, it slows the machine down when developing...