Provide useful messages for missing files #96

Activity

1. gaearon

   added

   enhancement

   contributions: up for grabs!

   on Jul 22, 2016
2. apoorvnandan commented on Jul 22, 2016

   

   apoorvnandan

   on Jul 22, 2016

   More actions

   Hey, I would like to work on this but I need some guidance. Will using npm file-exists before opening the browser do the job?

   var fileExists = require('file-exists');
   if (!fileExists("/index.html") || !fileExists("/favicon.ico") || !fileExists("/src/index.html")) {
     console.log("File missing");
   }
   else {
     console.log(chalk.cyan('Starting the development server...'));
     openBrowser();
   }
   
3. gaearon commented on Jul 22, 2016

   

   gaearon

   on Jul 22, 2016

   ContributorAuthor

   More actions

   I would suggest to try implementing something that works and feels good. When we get the right UX we can choose to make changes to the actual implementation.
4. christophior commented on Jul 22, 2016

   

   christophior

   on Jul 22, 2016

   More actions

   Might take a look at this as well, I see that we already have paths that we're getting in the webpack configs so I was thinking of pulling those out since a lot of it seems like redundant data so that I could also use that in checking whether the required files exist.
5. vincaslt commented on Jul 22, 2016

   

   vincaslt

   on Jul 22, 2016

   More actions

   I guess something like that could work, tell me if it should be improved. Maybe move required file definitions to somewhat more manageable place?

   👍React with 👍1Reacted by Ivan Serniaev
6. delorge commented on Aug 3, 2016

   

   delorge

   on Aug 3, 2016

   Last edited by delorge

   More actions

   Is it easier to check that file exists via access check? Should work with any npm version. Moreover, no extra dependencies needed.

   UPD: we can basically crash on errors and warn on missing favicon

   👍React with 👍1Reacted by James Gardner
7. gaearon commented on Sep 18, 2016

   

   gaearon

   on Sep 18, 2016

   ContributorAuthor

   More actions

   This should be fixed in 0.4.2.
8. gaearon

   closed this as completedon Sep 30, 2016
9. grengojbo

   added a commit that references this issue on Nov 18, 2017

   Merge pull request react#96 from CADBOT/update-readme

   ...

   580bb2e
10. lock

    locked and limited conversation to collaborators on Jan 22, 2019