Missing peer dependency in react-scripts #8022

Activity

1. Andarist

   added

   needs triage

   on Nov 24, 2019
2. ianschmitz commented on Nov 24, 2019

   

   ianschmitz

   on Nov 24, 2019

   Last edited by ianschmitz

   Contributor

   More actions

   Hmm it would seem you're correct: https://github.com/yarnpkg/yarn/pull/6671/files.

   Adding under peerDependencies will start throwing warnings for folks that don't have npm@6.11.0 or later.

   We may want to do this as part of our v4 release. I'll mark as such and see what the other maintainers think.
3. ianschmitz

   added this to the 4.0 milestone on Nov 24, 2019
4. ianschmitz

   added

   issue: install problem

   and removed

   needs triage

   on Nov 24, 2019
5. Andarist commented on Nov 24, 2019

   

   Andarist

   on Nov 24, 2019

   ContributorAuthor

   More actions

   From what I understand CRA+TS would be broken for strict package managers like pnpm or yarn in pnp mode without this peer dependency specified. I was facing similar problem lately for the other package and we decided to just go with specifying peer dep and marking it as optional. We can always recommend using new version of npm and on older versions it will merely cause a warning - things will still be very much functional, so... 🤷‍♂
6. ianschmitz commented on Nov 24, 2019

   

   ianschmitz

   on Nov 24, 2019

   Last edited by ianschmitz

   Contributor

   More actions

   Good point. Oct 21 appears to have been the first Node release that included npm >= 6.11. I'm okay with the warning to support the other package managers.
7. ianschmitz

   modified the milestones: 4.0, 3.4, 3.3 on Nov 24, 2019
8. iansu

   closed this as completedin #8038on Nov 28, 2019
9. lock

   locked and limited conversation to collaborators on Dec 3, 2019