Skip to content

Typescript template serviceWorker.ts has a dead link #7886

Closed

Description

@tjquillan

Describe the bug

The Typescript template serviceWorker.ts has a dead link on line 11 (https://bit.ly/CRA-PWA) which I believe should be directing to https://create-react-app.dev/docs/making-a-progressive-web-app/

Did you try recovering your dependencies?

No this is not in the nature of the bug

Which terms did you search for in User Guide?

(Write your answer here if relevant.)

Environment

Environment Info:

  System:
    OS: Linux 5.3 Arch Linux undefined
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
  Binaries:
    Node: 12.13.0 - /usr/bin/node
    Yarn: 1.19.1 - /usr/bin/yarn
    npm: 6.12.0 - /usr/bin/npm
  Browsers:
    Chrome: Not Found
    Firefox: 70.0
  npmPackages:
    react: ^16.11.0 => 16.11.0 
    react-dom: ^16.11.0 => 16.11.0 
    react-scripts: 3.2.0 => 3.2.0 
  npmGlobalPackages:
    create-react-app: Not Found

Steps to reproduce

(Write your steps here:)

  1. Open serviceWorker.ts
  2. Click on the link: https://bit.ly/CRA-PWA

Expected behavior

I expected to be taken to a page on making a progressive web app

Actual behavior

The link directs to a 404 Page not found
image

Reproducible demo

The base Typescript template "reproduces" this issue

Activity

  1. kichel98 commented on Oct 26, 2019

    @kichel98

    The same link exists in index.js file:

    // If you want your app to work offline and load faster, you can change
    // unregister() to register() below. Note this comes with some pitfalls.
    // Learn more about service workers: https://bit.ly/CRA-PWA/   
    serviceWorker.unregister();
    
  2. stale commented on Nov 25, 2019

    @stale

    This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

  3. locked and limited conversation to collaborators on Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions