Upgrade typescript-eslint to v2 #7529

Activity

1. iansu

   added

   issue: typescript

   on Aug 14, 2019
2. chibicode commented on Aug 14, 2019

   

   chibicode

   on Aug 14, 2019

   Last edited by chibicode

   Contributor

   More actions

   @typescript-eslint/no-angle-bracket-type-assertion is deprecated. So we need to change this line:

   https://github.com/facebook/create-react-app/blob/4410f5ec30783cc60360b6e2306b95eead56c015/packages/eslint-config-react-app/index.js#L81

   It's now called @typescript-eslint/consistent-type-assertions. I believe it can be set as:

   { assertionStyle: 'as', objectLiteralTypeAssertions: 'allow' }

   Not so sure about objectLiteralTypeAssertions though. There wasn't any existing rule on our config related to this.

   👍React with 👍13Reacted by Oliver Kuldmäe, stevenjlho, Josias, LongP10, Jannis Hell, Martijn Senden, yamagen0915, fun4wut, Dariusz Winkler, Maciej Suchecki and 3 more
3. ianschmitz

   self-assigned this

   on Sep 9, 2019
4. ianschmitz

   closed this as completedin #7540on Sep 11, 2019
5. GLoganDR commented on Sep 11, 2019

   

   GLoganDR

   on Sep 11, 2019

   More actions

   Is there a release ETA for this? I see it's already been PRed and merged. Great job and thanks, btw! 👍

   👍React with 👍3Reacted by Stephen Haney, Ali Hassan and Maciej Suchecki
6. lock

   locked and limited conversation to collaborators on Sep 16, 2019