Can not start app using grpc web due to incorrect eslint errors #7295

Activity

1. Globegitter

   added

   issue: bug

   on Jun 28, 2019
2. Globegitter

   changed the title [-]Can not start app using grpc web due to eslint[/-] [+]Can not start app using grpc web due to incorrect eslint errors[/+] on Jun 28, 2019
3. heyimalex commented on Jun 28, 2019

   

   heyimalex

   on Jun 28, 2019

   Contributor

   More actions

   Give me some way to ignore specific files/directories from being linted, or give me an option turn errors into warnings so I can choose to ignore false positives.

   The maintainers are averse to adding more configuration to CRA, especially when there are already multiple ways to handle it. I know it sucks, but I think it'd be smart to try and find another way. no-undef is an incredibly common eslint rule; maybe try lobbying at grpc-web for a flag that adds the ignore line for you.
4. Globegitter commented on Jun 30, 2019

   

   Globegitter

   on Jun 30, 2019

   Author

   More actions

   To be honest I am happy with any fix that would be accepted, those are just the things I could think of. But you think there is nothing that could/would be changed here?
5. karbica commented on Jul 12, 2019

   

   karbica

   on Jul 12, 2019

   Last edited by karbica

   More actions

   @Globegitter I am suffering from the same issue as well. This is entirely on the CRA team and their position to keep the .eslintignore file from being exposed/supported to the developer.

   I can't seem to find any other work around other than what was discussed here. Both parties are going to be pretty stubborn about this.

   So, adding that line manually can be tedious if you need an automated solution. What I decided to do was immediately transform the files generated by protoc. You can then have a script in your package.json that executes some Bash code to prepend the required line /* eslint-disable */.

   #!/usr/bin/env bash
   
   # pb_disable_eslint.sh
   # you can use it like so:
   # ./pb_disable-eslint.sh ./my/path/to/proto/dir
   
   for F in $(ls -A1 $1)
   do
   echo "Prepending file: $F"
   echo '/* eslint-disable */' | cat - $F > temp && mv temp $F
   done

   If you are uncomfortable with the Bash file, you can use glob and the native fs module to modify the output directory of protoc.

   This all would have been easier if we could just control our own .eslintignore file just like all the other ignore files.
6. Globegitter commented on Jul 12, 2019

   

   Globegitter

   on Jul 12, 2019

   Author

   More actions

   Yeah, I came up with a similar solution in the end - we are just using a gradle task in combination with https://github.com/google/protobuf-gradle-plugin for it. Would be nice to have something more permanent but at least it is workable.
7. thepont commented on Dec 8, 2019

   

   thepont

   on Dec 8, 2019

   Last edited by thepont

   More actions

   Just had this issue was well and opted for changing the scripts in the package.json as such. ( this tells the react script to not ignore your changes to the eslint config. ( perplexing that this isn't the default )

     "scripts": {
       "start": "EXTEND_ESLINT=true react-scripts start",
       "build": "EXTEND_ESLINT=true react-scripts build",
       "test": "react-scripts test",
       "eject": "react-scripts eject"
     }

   and then modifying the eslintrc to ignore protobuf files.

     "eslintConfig": {
       "extends": "react-app",
       "overrides" : [
         {
        	  "files": "**/*.js",
             "excludedFiles": "**/*_pb.js"
         }
       ]
     }

   This was made possible due to a fix in #6f5221c

   👍React with 👍5Reacted by Gabor Dolla, aktx, Thomas Gale, Jonathan Zernik and Hwa Soo Kang

   👎React with 👎1Reacted by Rob Rodriguez

   ❤️React with ❤️1Reacted by aktx