Repository navigation
Fix end-to-end test to use packages from master #698
Description
As noted in #696 (comment), we should have end-to-end test use the versions of packages from the repo instead of ones from npm. We might need to run lerna bootstrap in it or something.
Activity
fson commentedon Sep 22, 2016
It's weird that it only fails in Node v4.5.0, not in 6. We already run
lerna bootstrapin the npmpostinstallscript so that should work.I also tried running locally on a fresh Node v4.5.0 installation and
npm installworked without any errors about peer dependencies.fson commentedon Sep 22, 2016
I see what the problem is now, we run
npm installagain in thereact-scriptspackage after copying it to a clean directory withoutnode_modules. At that point the packages are not bootstrapped, so it installs all the packages from npm.I think the release script possibly needs to be changed too, because it uses the same strategy when it bundles the dependencies. Unless we publish all the other packages first, the script will bundle the eslint-config-react-app from npm. Perhaps we could make this easier by publishing everything with
lerna publishand moving the special handling forreact-scripsto a prepublish script, so that it will (hopefully) run after the version numbers have been updated?fson commentedon Sep 22, 2016
The e2e test should be fixed here: #699.
gaearon commentedon Sep 22, 2016
Thanks!
gaearon commentedon Sep 23, 2016
#723 (comment)