You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
hey! yea sure. really you just have to push this up on Netlify and its a button click away. do you want to do it on your own account? if i do it on mine i don't think i can transfer it over to you.
just let me know when youve done it and i'll put you on the free OSS plan.
That's something we need to figure out. Do we also need to install something in the GitHub repo so the link to the deploy appears on each PR? If so we'll need to ask @gaearon to do that.
@gaearon and @iansu apologies for the confusion. some setup was needed to deploy this monorepo/docusaurus setup. the best way to do this is with a netlify.toml configuration - in #5930 i have created a PR to set that up in CRA.
it is deployed from my fork of CRA, and i have enabled the PR deploy preview setting so that you can see how it might look when someone makes a PR into the docs:
deploy logs are open so people will be able to tell if they made a PR that fails the build. and members of the Netlify "react" team should be able to make other settings adjustment.
no bandwidth worries b/c you'd be on the unofficial "OSS plan"
i was forced to set a redirect from / to /create-react-app because of the baseUrl setting in docusaurus - if we do proceed with netlify we can get rid of that.
choose the facebook org and search for the c-r-a repo
that will get you to where dan was above but this time you dont need to write any build settings, its done for you by the config. leave the settings blank and just hit "Deploy site".
Once its deployed we can worry about naming. Do you want create-react-app.netlify.com? or do you want some more custom domain? (cra.io?) could even consider facebook.netlify.com/create-react-app. we have someone squatting on https://cra.netlify.com/ but we could boot them if you want.
Deployed! I'm not sure about the domain name right now. I think we will continue using the GitHub pages URL until we come up with something better. This is a great start though. Now we can preview the docs when someone submits a PR. 🎉
@sw-yx I'd like to change the name of our app to just create-react-app but it seems like it's not available. It doesn't really seem to be in use though. Can you help with that?
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.
Activity
iansu commentedon Nov 14, 2018
Maybe @sw-yx can help us out with this?
swyxio commentedon Nov 14, 2018
hey! yea sure. really you just have to push this up on Netlify and its a button click away. do you want to do it on your own account? if i do it on mine i don't think i can transfer it over to you.
just let me know when youve done it and i'll put you on the free OSS plan.
iansu commentedon Nov 14, 2018
That's something we need to figure out. Do we also need to install something in the GitHub repo so the link to the deploy appears on each PR? If so we'll need to ask @gaearon to do that.
swyxio commentedon Nov 14, 2018
hmm. might need to install the Netlify Github app, yes. but it might already be installed since reactjs.org is on netlify.
iansu commentedon Nov 14, 2018
At the very least it will be easier to convince someone to install it if React is already using it.
swyxio commentedon Nov 14, 2018
alright lets wait for Dan to see this. sounds like you do need an install
gaearon commentedon Nov 28, 2018
I don't know what to do with this. If someone gives me exact instructions I can set it up. :-)
iansu commentedon Nov 28, 2018
I'll see if I can get this working with my fork of CRA and post some more specific instructions.
swyxio commentedon Nov 30, 2018
@gaearon and @iansu apologies for the confusion. some setup was needed to deploy this monorepo/docusaurus setup. the best way to do this is with a netlify.toml configuration - in #5930 i have created a PR to set that up in CRA.
You can see the result of this deploy here: https://trusting-lichterman-ee04c1.netlify.com
/to/create-react-appbecause of thebaseUrlsetting in docusaurus - if we do proceed with netlify we can get rid of that.Add netlify.toml to prepare for deploy to netlify #5807 (#5930)
iansu commentedon Nov 30, 2018
This is awesome. Thanks! 🎉
I think the
baseUrlis set to/create-react-appbecause we're deploying to GitHub pages.What do we need to do to get this finished? I see that Dan has already merged your config PR. What else do you need from us?
swyxio commentedon Nov 30, 2018
just need to proceed with the deploy :) You or Dan can do it since you should be on the "react team" within Netlify.
Once its deployed we can worry about naming. Do you want
create-react-app.netlify.com? or do you want some more custom domain? (cra.io?) could even considerfacebook.netlify.com/create-react-app. we have someone squatting onhttps://cra.netlify.com/but we could boot them if you want.iansu commentedon Dec 1, 2018
Deployed! I'm not sure about the domain name right now. I think we will continue using the GitHub pages URL until we come up with something better. This is a great start though. Now we can preview the docs when someone submits a PR. 🎉
iansu commentedon Dec 1, 2018
Thanks for all your help @sw-yx! 😀
iansu commentedon Dec 3, 2018
@sw-yx I'd like to change the name of our app to just
create-react-appbut it seems like it's not available. It doesn't really seem to be in use though. Can you help with that?swyxio commentedon Dec 3, 2018
yup on it. will take a while, i have to follow procedure with the squatter
Update: squatter gave the ok. Should be released for you to claim by tomorrow
Merge branch 'master' into checkYarnRegistry
stale commentedon Jan 3, 2019
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.
iansu commentedon Jan 3, 2019
This is done!