Skip to content

Confusing usage of webpack rule.loader in react-scripts #5736

Closed
Closed
Confusing usage of webpack rule.loader in react-scripts#5736

Description

@dbFlower
dbFlower
opened on Nov 7, 2018

In webpack.config.prod.js L391 L405 L420 L437, loaderis used instead of use. See: webpack.config.prod.js .

In file webpack.config.dev.js L318 L326 L340 L346 , it's correct usage use. See: webpack.config.dev.js

Webpack4 documentation here:

Rule.loader is a shortcut to Rule.use: [ { loader } ]. See Rule.use and UseEntry.loader for details.

Activity

  1. Timer commented on Nov 7, 2018

    @Timer
    Timer
    on Nov 7, 2018
    Contributor

    This was fixed as part of #5722

  2. Timer
    closed this as completedon Nov 7, 2018
  3. lock
    locked and limited conversation to collaborators on Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions