Repository navigation
Paths are incorrectly resolved when react-scripts is a shared dependency #556
Description
Not sure if we want to (or even can) support this use case, but this doesn't currently work:
- proj
- package.json # contains react-scripts
- node_modules
- react-scripts
- a
- package.json # does not contain react-scripts but has npm start
- src
- b
- package.json # does not contain react-scripts but has npm start
- src
Technically this is valid in npm, but CRA thinks it’s running in local development mode.
Activity
gaearon commentedon Sep 2, 2016
@Jiansen Could you take a look at this? Curious if you have ideas.
gaearon commentedon Sep 2, 2016
The good part is this never worked before, so at least it’s not a regression.
Jiansen commentedon Sep 3, 2016
I will take a look.
@remove-on-publish-begin/endshould remove local dev only code.Before we had
@remove-on-publish/eject-begin/end, we use path compare to determine if CRA is running in local dev, as an npm module, or after eject. We should hopefully be able to remove those checks now.gaearon commentedon Sep 3, 2016
Thanks!
Timer commentedon Mar 14, 2017
Retagging this for 0.10, but we might've already fixed this with our recent path changes.
Please check before working on it. :)
gaearon commentedon May 15, 2017
I think the remaining issue will be fixed by #2166.