Sass support in jest test files appear to be broken

Is this a bug report?

Yes

Did you try recovering your dependencies?

Yes

(Write your answer here.)

Which terms did you search for in User Guide?

Sass support

(Write your answer here if relevant.)

Environment

node -v:
npm -v:
yarn --version (if you use Yarn):
npm ls react-scripts (if you haven’t ejected):

Then, specify:

Operating system:
Browser and version (if relevant):

Steps to Reproduce

(Write your steps here:)

1: Update react-scripts to latest release
2: Import styles from 'component.module.scss' in component file
3: Import styles from 'component.module.scss' in component.test.js

Expected Behavior

(Write what you thought would happen.)

Classnames are imported for component file and test file correctly for comparison

see #3815

Actual Behavior

(Write what happened. Please add screenshots!)

Component imports classNames correctly, test file classnames are undefined

Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

This is because we don't have scss preprocessor configured for jest. And I am guessing the same problem will be there when we use .module.css files.

Can I work on this?

I'm going to attempt a PR too :)

Would it be a good idea to follow the 'mocking css modules' section of the jest-webpack documentation found here?

https://facebook.github.io/jest/docs/en/webpack.html#mocking-css-modules

This would allow tests to check that correct classNames were being applied without having to set up preprocessor transforms.

This is odd, because we already configured that for CSS Modules (and I believe we even have tests); I wonder why Sass isn't working (or is just not what's expected)?

Ah, it appears we need to add {sass,scss} to these locations:

https://github.com/facebook/create-react-app/blob/789b856b13693f14d89cb9c4622ae7c8f08a6069/packages/react-scripts/scripts/utils/createJestConfig.js#L46-L49

https://github.com/facebook/create-react-app/blob/789b856b13693f14d89cb9c4622ae7c8f08a6069/packages/react-scripts/scripts/utils/createJestConfig.js#L52

I'd be happy to make a PR on this, one question however (I cannot seem to find an answer in the documentation I have searched), How am I supposed to test my change with the cloned repo? I cannot see any way to test the changes with a generated create-react-app. Also if I were able to generate an app using the changes, shall I just have the extra generated files not committed then make a PR? Sorry in advance if these are dumb questions. Fairly new to the contributing thing.

You can test your changes by running yarn create-react-app my-app from the base of your cloned repo. That will create a new app called my-app using your local changes.

You should not commit my-app when submitting a PR. You can create my-app outside of your cloned repo by doing something like this instead: yarn create-react-app ../my-app.

It appears that after modifying createJestConfig.js and generating an app, doing the following:
import styles from test.module.scss
results in:
console.log(styles) // => 'test.module.scss'

So it appears to be importing the sass module as a string of the file name. I'm going to continue looking into this, if this pops out to you as something obvious then feel free to let me know. :)

I think I have an idea, going to test it tomorrow as generating the node_modules folder every time for CRA is murdering my mobile internet.

it also appears that importing css modules is not working as expected either.

import styles from './test.module.css';
import sass from './sass.module.scss';

it('should handle css modules', () => {
  console.log(styles) // => {}
})

it('should handle sass modules', () => {
  console.log(styles) // => 'sass.module.scss'
})

Using this configuration:

transformIgnorePatterns: [
      '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs)$',
      '^.+\\.module\\.{css,sass,scss}$',
    ],
    moduleNameMapper: {
      '^react-native$': 'react-native-web',
      '^.+\\.module\\.{css,sass,scss}$': 'identity-obj-proxy',
    },

Accidental close and comment*

I'm unsure how to continue this unfortunately, if anyone has some ideas as to the strange behaviour above, otherwise i'll keep this here to see if anyone else wants to pick this up. :)

it also appears that importing css modules is not working as expected either.

import styles from './test.module.css';
import sass from './sass.module.scss';

it('should handle css modules', () => {
  console.log(styles) // => {}
})

it('should handle sass modules', () => {
  console.log(styles) // => 'sass.module.scss'
})

Hello, this is still an issue which basically prevents me from testing conditional class assginment as in:

const Tile = ({ tilePlacement }) => (
  <div className={styles[`tile_${tilePlacement}`] || styles.default} />
)

will, in Jest, never return default but tile_[tilePlacementValue]

Navigation Menu

Repository navigation

Sass support in jest test files appear to be broken #4345

Is this a bug report?

Did you try recovering your dependencies?

Which terms did you search for in User Guide?

Environment

Steps to Reproduce

Expected Behavior

Actual Behavior

Reproducible Demo

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Sass support in jest test files appear to be broken #4345

Description

Is this a bug report?

Did you try recovering your dependencies?

Which terms did you search for in User Guide?

Environment

Steps to Reproduce

Expected Behavior

Actual Behavior

Reproducible Demo

Activity

Aftabnack commented on Apr 23, 2018

Tasemu commented on Apr 23, 2018

Tasemu commented on Apr 24, 2018

Timer commented on Apr 24, 2018

Timer commented on Apr 24, 2018

Tasemu commented on Apr 24, 2018

iansu commented on Apr 24, 2018

Tasemu commented on Apr 24, 2018

Tasemu commented on Apr 24, 2018

Tasemu commented on Apr 25, 2018

Tasemu commented on Apr 25, 2018

Tasemu commented on Apr 27, 2018

dawidsok commented on Oct 23, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions