Skip to content

Proxy defined via package.json is slow #4086

Closed

Description

@VladoDemcak

We have proxy defined in package.json in our react application and We use proxy between front-end (webpack) and back-end (express) during development as described here.
package.json:

  "scripts": {
    ...
  },
  "proxy": "http://localhost:3001"
}

So as you can see it's simple proxy as described in documentation.
On the backend side (port 3001) we call another APIs (another rest services).
I have noticed that proxy calls from webpack (create-react-app) to express (backed) during development are really slow. (we work on Windows OS)

GET http://localhost:3000/endpoint/ -> ~600ms - 900ms (webpack -> express -> 3rd party rest api)
GET http://localhost:3001/endpoint/ -> ~150ms - 250ms (express -> 3rd party rest api)
GET http://restAPI:XYZ/endpoint/    -> ~150ms - 250ms (3rd party rest api direct call)

As you can see the time differences between proxy calls (port 3000) and direct calls - port (3001) - are really huge. I expected delay but this looks weird.

Also sometimes large JSON response (~38KB) from proxy is broken (invalid - e.g missing some parts of a response or swapped characters). I have been struggling with the same issue on backend side and I think I have resolved it with proxy-agent where I set keep-alive connection.

Do you have any idea why or how to improve proxy time and behavior?

Also I tried to set agent in package.json but without success.
create react app documentation says:

You may also specify any configuration value http-proxy-middleware or http-proxy supports.

And http-proxy documentation says

agent: object to be passed to http(s).request (see Node's https agent
and http agent objects)

Is it possible to define agent in package.json?

I tried but I got following error

TypeError: Agent option must be an Agent-like object, undefined, or
false.
at new ClientRequest (_http_client.js:106:11)

"proxy": {
    "/": {
      "target": "http://localhost:3001",
      "agent": { "keepAlive": true }
    }
  }

Highly appreciate any suggestion or idea.

Activity

  1. VladoDemcak commented on Mar 3, 2018

    @VladoDemcak
    Author

    We are forced to use react-app-rewired for custom agent. It's sad that we were not able to set our custom agent for devServer proxy. At least we didn't find a way how to make this work.

    // config-overrides.js
    module.exports = {
      devServer: function(configFunction) {
        return function(proxy, allowedHost) {
          const config = configFunction(proxy, allowedHost);doesnt work very well
          config.proxy.forEach(p => {
            p.agent = agent; //  new http.Agent({ keepAlive: true });
          });
          return config;
        };
      }
    }
    

    I guess it's workaround and potentially not supported in the future releases of create-react-app but response time is around 150ms - 230ms (AND! without invalid JSONs) and it's the thing that counts right now.

    ENVIRONMENT:
    Windows 10 Version 1703
    npm --version 5.7.1
    node --version v8.9.1
    
  2. added this to the 2.x milestone on Mar 5, 2018
  3. yyfearth commented on Mar 11, 2018

    @yyfearth

    I think the proxy.js mentioned in #3366 and #3845 will solve your problem.

  4. VladoDemcak commented on Mar 12, 2018

    @VladoDemcak
    Author

    Nice note @yyfearth !. Didn't know about proxy.js. I checked it and I definitely agree with you.

  5. removed this from the 2.x milestone on Nov 2, 2018
  6. stale commented on Dec 2, 2018

    @stale

    This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

  7. stale commented on Dec 8, 2018

    @stale

    This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.

  8. locked and limited conversation to collaborators on Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions