Repository navigation
Make it a proper multipackage monorepo #403
Description
I think we should change the directory structure to make it easier to add more packages to the project in the future. I’m thinking something like this:
packages
- create-react-app (this is global-cli in current layout)
- index.js
- package.json
- react-scripts (this is project root in current layout)
- bin
- config
- scripts
- package.json
tasks
template
A PR doing this is welcome. (You’ll probably want to adjust config/paths.js to account for this change.)
If you plan to work on this please leave a comment here so multiple people don’t work on the same thing. Please respect it if somebody has taken the task, and let them finish it.
Activity
gaearon commentedon Aug 8, 2016
(There is no need to add something like Lerna yet, I think, but if you’re sure it’s better then go ahead with it. Note that we want to have independent versioning for all packages.)
ryanyogan commentedon Aug 8, 2016
I'd like to take a crack at this tonight/tomorrow if no one else started?
gaearon commentedon Aug 8, 2016
Sounds good @ryanyogan!
suchipi commentedon Aug 8, 2016
Some discussion on the topic that might be worth considering: https://github.com/boennemann/alle
ryanyogan commentedon Aug 8, 2016
Thanks @suchipi I am going to look at that now.
I do like the philosophy behind Lerna however I do concur with @gaearon that it may be overkill at this time.
I personally believe the project is small enough at this time adding additional complexities may incur more cost later. But crack an egg of wisdom on me if you feel strongly otherwise!
hzoo commentedon Aug 8, 2016
I agree Lerna isn't necessary atm but it's relatively simple to setup with independent mode (you don't need crazy options)
Should write up that usage guide sometime..
ryanyogan commentedon Aug 8, 2016
I'll crack a branch with the basic requirements, then I will toy around with Lerna's independent mode.
I don't think it could hurt to show two variants, and let you all decide on what ya like better. I prefer simplicity until required, but from what it looks like Lerna independant is perhaps a fair compromise.
hzoo commentedon Aug 8, 2016
If it isn't too much overheard, but otherwise yeah just stick with what works/simple.
Created packages directory (react#403)
Updated package.json paths and travis cache directory (react#403)
Updated paths, moved package.json to react-scripts dir (react#403)
30 remaining items
boxxxie commentedon Aug 29, 2016
i suggest waiting until lerna uses symlinks (this is part of one of the PRs that is about to be merged)
gaearon commentedon Sep 24, 2016
Done thanks to @ryanyogan and @fson. This unlocked many opportunities for us so thank you for moving this project forward.
ryanyogan commentedon Sep 26, 2016
No problemo, once my schedule gets a tad calmer I can't wait to start
creating some plugins, or whatever the group decides on for extending upon
the mono repo!
On Sat, Sep 24, 2016 at 5:51 AM, Dan Abramov notifications@github.com
wrote: