Repository navigation
CRA + proxy + HTTPS=true issues with OAuth flow #3245
Description
Is this a bug report?
yes
Environment
-
node -v: 8.3.0 -
npm -v: 5.4.2 -
yarn --version(if you use Yarn): 1.1.0 -
npm ls react-scripts(if you haven’t ejected): -
Operating system: OSX
Steps to Reproduce
- I have express.js app running on http://localhost:5000
- I have Oauth google setted up.
- I have CRA app installed.
- I have added target proxy setted in CRA's package:
"proxy": {
"/auth/google": {
"target": "https://localhost:5000"
}
},
- I have
npm startscript modified to enable self signed SSL certificate in CRA's package.json as it recommended by README:
"scripts": {
"start": "HTTPS=true react-scripts start"
}
- I have link with relative path, embedded to React app, which should proxy to
https://localhost:5000/auth/google:
<a href='/auth/google'>Sign In with Google</a>
Expected Behavior
Redirect tohttps://accounts.google.com/signin/oauth/...... to confirm signup:
Actual Behavior
Receiving error in browser:
Proxy error: Could not proxy request /auth/google from localhost:3000 to https://localhost:5000 (ECONNRESET).
PS: If I set proxy in package.json to HTTP instead of HTTPS:
"proxy": {
"/auth/google": {
"target": "http://localhost:5000"
}
},
and remove HTTPS=true from npm start script, everything works, but my paranoia tells me that in dev mode it is better to be protected, cos some malicious browser extensions could mess with the code.
Sorry, I do not have demo.
Activity
[-]CRA + proxy + HTTP=true issues with OAuth flow[/-][+]CRA + proxy + HTTPS=true issues with OAuth flow[/+]javialej11 commentedon Nov 29, 2017
Yes, i have the same issue the request with proxy doesn´t works & i don´t find info about it! Please help us
JustFly1984 commentedon Dec 1, 2017
I Solved it only by ejecting CRA and several additional steps to totally get rid of proxy.
The main thing you need to edit after ejecting is
/config/webpackDevServer.config.jsfile and/scripts/start.jsYou need to find all the
proxyinstances and remove them.I will recommend you to use ESlint while refactoring.
gaearon commentedon Jan 8, 2018
Do you have a proposed fix we could apply on our side?
JustFly1984 commentedon Jan 11, 2018
I think you need to make proxy optional/configurable, so it could be easy to disable/enable without ejecting CRA.
gaearon commentedon Jan 11, 2018
We've been trying to consolidate the proxy discussion in #3366. Could you please write your input there, and try to figure out with other posters what changes to the API/configuration would be ideal? Thanks.
gaearon commentedon Jan 14, 2018
Now that I re-read your comment, I'm not sure I understand what happened.
Proxy definitely is disabled by default. Yes, there is a call to prepare its config, but it returns undefined when there is no
proxysetting.What you describe sounds either like a bug or a misunderstanding. Maybe passing
proxy: undefinedsomehow still has effect? I'm not sure.Can you describe the symptoms in more detail so we can verify them?
In particular I don't see how your first symptom (something doesn't work with OAuth when you do specify proxy) is related to your second symptom (something doesn't work when you don't specify proxy).
JustFly1984 commentedon Jan 14, 2018
The issue was: I develop with HTTPS=true env, so proxy didn't work with HTTPS=true for me at least.
I think something was messing up with CORS, and I could fix it only after ejecting.
Sorry I moved on very far since then, and can't reproduce it now. I think I had this issue with CRA 1.0.7
gaearon commentedon Jan 14, 2018
I see. I’m going to close this as there’s not enough detail for us to dig into this. But if somebody else encounters this, or you see it again, please file a new issue with a reproducing example. Thanks!