Skip to content

npm start does not detect modifications in src/*/node_modules #3223

Closed

Description

@mariuskava

Is this a bug report?

yes

Can you also reproduce the problem with npm 4.x?

yes

Which terms did you search for in User Guide?

node_modules, watch, absolute, relative, import, webpack
(also searched the change logs)

Environment

  1. node -v: v8.6.0
  2. npm -v: 4.6.1 and 5.4.2
  3. yarn --version (if you use Yarn): ---
  4. npm ls react-scripts (if you haven’t ejected):
    └── react-scripts@1.0.14

(and I also tried react-scripts@0.9.5 and react-scripts@1.0.0 versions. There is no problem with 0.9.5)

  1. Operating system: Windows 8.1 and Ubuntu xenial
  2. Browser and version (if relevant): not relevant

Steps to Reproduce

  1. create-react-app test
  2. create file at test/src/node_modules/Test.js with: console.log("Test.js imported");
  3. at test/src/index.js: import "Test.js";
  4. cd test && npm start
  5. modify test/src/node_modules/Test.js;
  6. modify test/src/index.js;

Expected Behavior

at step 5. the project should recompile.
at step 6. the project should recompile with modified Test.js file.

This was the behavior with react-scripts@0.9.5-0.8.4. Downgrading fixes the issue.
Braking change was not reported on 0.9.5 -> 1.0.0.

Actual Behavior

at step 5. the project is not recompiled.
at step 6. the project is recompiled, but without Test.js modifications.

The project compiles without errors initially on npm start.

Reproducible Demo

create-react-app test
cd test
mkdir src/node_modules
echo "console.log("Test.js imported");" > src/node_modules/Test.js
mv src/index.js src/index.js.old
echo "import "Test.js";" > src/index.js
cat src/index.js.old >> src/index.js
rm src/index.js.old
npm start

(then make modifications on Test.js file)

Activity

  1. Timer commented on Oct 1, 2017

    @Timer
    Contributor
  2. Timer commented on Oct 2, 2017

    @Timer
    Contributor

    We'll need someone to take over #2760 and champion it. 😄

  3. added this to the 1.0.x milestone on Oct 2, 2017
  4. added a commit that references this issue on Oct 3, 2017
    1e98d0f
  5. modified the milestones: 1.0.x, 1.0.15 on Oct 28, 2017
  6. gaearon commented on Oct 30, 2017

    @gaearon
    Contributor
  7. added a commit that references this issue on Aug 14, 2018
    3dae2d8
  8. locked and limited conversation to collaborators on Jan 21, 2019
  9. added a commit that references this issue on Oct 8, 2024
    a3650b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions