Skip to content

Add .gitattributes file #3080

Closed
Closed
Add .gitattributes file#3080
Labels
contributions: claimeddifficulty: starter
Milestone
1.x

Description

@Timer
Timer
opened on Sep 6, 2017

Windows contributors have to deal with failing test cases due to line endings when comparing to snapshot tests.

See #3065 for reference.

We should create a .gitattributes file which forces these files (all *.js files?) to be checked out with LF line feeds.

Activity

  1. Timer
    added
    contributions: up for grabs!
    difficulty: starter
    on Sep 6, 2017
  2. Timer
    added this to the 1.x milestone on Sep 6, 2017

  3. duvet86 commented on Sep 7, 2017

    @duvet86
    duvet86
    on Sep 7, 2017
    Contributor

    I can help with this, given that it affects me.
    Cheers.

  4. Timer
    added
    contributions: claimed
    and removed
    contributions: up for grabs!
    on Sep 7, 2017

  5. Timer commented on Sep 7, 2017

    @Timer
    Timer
    on Sep 7, 2017
    ContributorAuthor

    Great, thanks!

  6. ijajmulani commented on Sep 13, 2017

    @ijajmulani
    ijajmulani
    on Sep 13, 2017
    Contributor

    Hi, looking to get involved in open source projects. If you want I can help you in this.

  7. ijajmulani
    added a commit that references this issue on Sep 13, 2017

    Fix for add .gitattributes file react#3080

    b076ce4

  8. ijajmulani commented on Sep 13, 2017

    @ijajmulani
    ijajmulani
    on Sep 13, 2017
    Contributor

    Here is my PR for same.

  9. duvet86 commented on Sep 23, 2017

    @duvet86
    duvet86
    on Sep 23, 2017
    Contributor

    Unfortunately I can't find a way to normalise files using .gitattributes.
    The only solution I've found is setting:
    git config --global core.autocrlf false

    As per stated here:
    https://stackoverflow.com/questions/2517190/how-do-i-force-git-to-use-lf-instead-of-crlf-under-windows/13154031#13154031

    Cheers Luca

  10. gaearon
    added a commit that references this issue on Oct 28, 2017

    Fix for add .gitattributes file #3080 (#3122)

    345f550
  11. kellyrmilligan
    added a commit that references this issue on Oct 31, 2017

    Merge branch 'master' into serve-app-under

    1515ab4
  12. gaearon
    closed this as completedon Jan 8, 2018
  13. suutari-ai
    added a commit that references this issue on Jan 25, 2018

    Merge branch 'master' of https://github.com/wmonk/create-react-app-ty…

    7227b64
  14. lock
    locked and limited conversation to collaborators on Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    contributions: claimeddifficulty: starter

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions