Repository navigation
Build errors are not printed to console due to broken require #2936
Description
Is this a bug report?
Yes
Can you also reproduce the problem with npm 4.x?
Yes.
The Problem
Build errors do not print to console to due to an fatal error introduced in PR #2650.
PR #2650 added a new file printBuildError.js, which requires lodash/get. However, lodash is not listed as a dependency in react-script's package.json, so any execution path that requires printBuildError.js will fail to require 'lodash/get', causing node to throw a fatal exception.
Proposed Resolution
'lodash' or 'lodash.get' should be added to package.json, or the 'lodash/get' require should be removed from printBuildError.js.
Activity
gaearon commentedon Aug 10, 2017
Also worth looking into why this didn't fail CI.
Timer commentedon Aug 10, 2017
Hi @svicalifornia; I'd love a bit more information -- are you ejected?
Timer commentedon Aug 10, 2017
Also, what version of
npmare you using?Really, this shouldn't bomb out with npm >= 3 as it does dependency flattening and
lodashis required byinquirer. Though it'd be technically correct to includelodash-- this should only blow up on npm < 3.Timer commentedon Aug 10, 2017
Fix up in #2938.
Timer commentedon Aug 10, 2017
Released in
react-dev-utils@3.1.1. Please upgrade!svicalifornia commentedon Aug 10, 2017
@Timer My colleague and I experienced the issue on systems running npm 4.2 and 5.1.0.
Thanks for the quick fix!
Timer commentedon Aug 10, 2017
Are you ejected?
svicalifornia commentedon Aug 10, 2017
We are not ejected, but we are using react-app-rewired to add loaders and plugins to our webpack config.
Timer commentedon Aug 11, 2017
Hmm interesting. Non determinism at its finest haha.
Glad all is working now!