In PR #257 , CI build reports `passing` while not all tests are done. The console log is [here](https://travis-ci.org/facebookincubator/create-react-app/jobs/148064348) (see line 171). I will think about this problem while fixing the permission problem.
Activity
mxstbr commentedon Jul 28, 2016
That's definitely a bug! Why did that exit on a 0 even though there was an error? /cc @vjeux
vjeux commentedon Jul 28, 2016
Two possible explanations.
It turns out that we didn't forward the error code when doing
npm run build, it has been fixed in Improve error handling within e2e.sh #244The shell error handling was refactored in Return proper exit code in bin/react-scripts via spawnSync (#252) #256 there may be a bug.
I have a meeting for the next hour but I'll look afterwards. Thanks for pinging me
vjeux commentedon Jul 28, 2016
Could you rebase and send a version that breaks? See if the problem still happens.
Jiansen commentedon Jul 28, 2016
@vjeux , I will do it and report back.
verify react#258 and react#256: add without +x to tasks/pack.sh, e2e.…
Jiansen commentedon Jul 28, 2016
It seems that #256 doesn't capture bugs like this.
I created a simplified branch and PR in my forked repo because we shall never merge this test PR into this repo.
Let me know if you'd like to suggest other tests.
Fix error logic in e2e script
gaearon commentedon Jul 29, 2016
I might have fixed this in 4d60f08.
Let’s see how it goes.